From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753599AbbCDWdf (ORCPT ); Wed, 4 Mar 2015 17:33:35 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37538 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753335AbbCDWdd (ORCPT ); Wed, 4 Mar 2015 17:33:33 -0500 Message-ID: <54F7883B.90704@codeaurora.org> Date: Wed, 04 Mar 2015 14:33:31 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Kumar Gala , linux-arm-msm@vger.kernel.org CC: Abhimanyu Kapur , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de Subject: Re: [PATCH v2 2/3] arm64: qcom: Add support for Qualcomm MSM8916 SoC References: <1425503602-24916-1-git-send-email-galak@codeaurora.org> <1425503602-24916-2-git-send-email-galak@codeaurora.org> In-Reply-To: <1425503602-24916-2-git-send-email-galak@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/15 13:13, Kumar Gala wrote: > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 1b8e973..4c8b119 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -177,6 +177,15 @@ config ARCH_MEDIATEK > help > Support for Mediatek MT65xx & MT81xx ARMv8 SoCs > > +config ARCH_QCOM > + bool "Qualcomm Platforms" > + select ARCH_REQUIRE_GPIOLIB > + select COMMON_CLK_QCOM > + select PINCTRL > + select SOC_BUS I imagine all we need is select PINCTRL here. SOC_BUS is not used, also we shouldn't force COMMON_CLK_QCOM to be Y instead of M so please drop that select. Also we dropped ARCH_REQUIRE_GPIOLIB in arm32 so it would match if we just relied on ARCH_WANT_GPIOLIB that arm64 has by default -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project