From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbbCDWxo (ORCPT ); Wed, 4 Mar 2015 17:53:44 -0500 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:16025 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbbCDWxm (ORCPT ); Wed, 4 Mar 2015 17:53:42 -0500 X-IronPort-AV: E=Sophos;i="5.11,343,1422950400"; d="scan'208";a="58467190" Message-ID: <54F78CF4.9040108@broadcom.com> Date: Wed, 4 Mar 2015 14:53:40 -0800 From: Arun Ramamurthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Arnd Bergmann CC: Ray Jui , , , , , , , , Arun Ramamurthy , , , , , , Subject: Re: [PATCHv1] rtc: bcm-iproc: Add support for Broadcom iproc rtc References: <1418757750-3628-1-git-send-email-arun.ramamurthy@broadcom.com> <3699327.0G6ZNxn8QA@wuerfel> <54F789CD.5030504@broadcom.com> <2569223.1gDQjv8f8j@wuerfel> In-Reply-To: <2569223.1gDQjv8f8j@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-03-04 02:50 PM, Arnd Bergmann wrote: > On Wednesday 04 March 2015 14:40:13 Arun Ramamurthy wrote: >> On 15-03-04 02:21 PM, Arnd Bergmann wrote: >>> On Thursday 12 February 2015 14:17:41 Arun Ramamurthy wrote: >>>> Hi Arnd >>>> >>>> My apologies for the late reply, I was moved to other work items. I >>>> wanted to get more clarification on the syscon issue so that I can >>>> submit the next patch set. If I understand correctly, you would like >>>> me to move the CRMU logic to a new driver under mfd/ and use the syscon >>>> api calls in my rtc driver? Thanks >>> >>> It depends a lot on what's in there, I can best advise you if you >>> have some form of register list. >>> >>> A common approach would be to not have a driver for the crmu at all, >>> but just mark it as syscon, and have the other drivers either reference >>> the syscon node through a phandle, or create them as childrem of >>> the syscon node. The latter case makes most sense if all uses of >>> the crmu have no other MMIO registers. >>> >> >> Thank you Arnd, I am going to follow the approach of adding a child node >> to the syscon node. Several other driver use other registers in the CRMU >> so I think the child node approach makes the most sense. > > Just to be sure we have the same understanding: of those other drivers, > do you think that they would use only CRMU registers, or could there > be drivers that have both CRMU as well as other MMIO registers? > The other drivers have both CRMU and other MMIO registers. So I thought they could also switch to using the syscon child nodes. > Arnd >