From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754281AbbCECUJ (ORCPT ); Wed, 4 Mar 2015 21:20:09 -0500 Received: from mail-ie0-f169.google.com ([209.85.223.169]:34063 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752633AbbCECUH (ORCPT ); Wed, 4 Mar 2015 21:20:07 -0500 Message-ID: <54F7BD54.5060502@gmail.com> Date: Wed, 04 Mar 2015 20:20:04 -0600 From: Kazutomo Yoshii User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org Subject: [PATCH] mm: fix do_mbind return value Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I noticed that numa_alloc_onnode() failed to allocate memory on a specified node in v4.0-rc1. I added a code to check the return value of walk_page_range() in queue_pages_range() so that do_mbind() only returns an error number or zero. Signed-off-by: Kazutomo Yoshii --- mm/mempolicy.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 4721046..ea79171 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -644,6 +644,7 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end, .nmask = nodes, .prev = NULL, }; + int err; struct mm_walk queue_pages_walk = { .hugetlb_entry = queue_pages_hugetlb, .pmd_entry = queue_pages_pte_range, @@ -652,7 +653,10 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end, .private = &qp, }; - return walk_page_range(start, end, &queue_pages_walk); + err = walk_page_range(start, end, &queue_pages_walk); + if (err < 0) + return err; + return 0; } /* -- 1.8.3.1