* [PATCH] ftracetest: Don't use non-POSIX exit -1
@ 2015-03-05 2:04 Michael Ellerman
2015-03-05 2:26 ` Steven Rostedt
2015-03-05 2:40 ` Masami Hiramatsu
0 siblings, 2 replies; 5+ messages in thread
From: Michael Ellerman @ 2015-03-05 2:04 UTC (permalink / raw)
To: shuahkh; +Cc: rostedt, linux-kernel, davej, namhyung
POSIX says that exit takes an unsigned integer between 0 and 255.
Convert exit -1 to exit 255.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
tools/testing/selftests/ftrace/test.d/00basic/basic4.tc | 2 +-
tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 2 +-
tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 2 +-
tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 2 +-
tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc | 2 +-
tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc | 2 +-
tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc b/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc
index fd9c49a13612..f6b9fc323ee0 100644
--- a/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc
+++ b/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc
@@ -2,4 +2,4 @@
# description: Basic event tracing check
test -f available_events -a -f set_event -a -d events
# check scheduler events are available
-grep -q sched available_events && exit 0 || exit -1
\ No newline at end of file
+grep -q sched available_events && exit 0 || exit 255
\ No newline at end of file
diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
index 668616d9bb03..59a352408284 100644
--- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
+++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
@@ -9,7 +9,7 @@ do_reset() {
fail() { #msg
do_reset
echo $1
- exit -1
+ exit 255
}
if [ ! -f set_event -o ! -d events/sched ]; then
diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
index 655c415b6e7f..1e4dbf06d690 100644
--- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
+++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
@@ -9,7 +9,7 @@ do_reset() {
fail() { #msg
do_reset
echo $1
- exit -1
+ exit 255
}
if [ ! -f set_event -o ! -d events/sched ]; then
diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
index 480845774007..6b6a12cba387 100644
--- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
+++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
@@ -9,7 +9,7 @@ do_reset() {
fail() { #msg
do_reset
echo $1
- exit -1
+ exit 255
}
if [ ! -f available_events -o ! -f set_event -o ! -d events ]; then
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
index c15e018e0220..7320344072ec 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
@@ -25,7 +25,7 @@ do_reset() {
fail() { # msg
do_reset
echo $1
- exit -1
+ exit 255
}
disable_tracing
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
index 6af5f6360b18..9f63b8081f7c 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
@@ -17,7 +17,7 @@ do_reset() {
fail() { # msg
do_reset
echo $1
- exit -1
+ exit 255
}
disable_tracing
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
index 2e719cb1fc4d..e01ea0a9764e 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
@@ -31,7 +31,7 @@ fail() { # mesg
reset_tracer
echo > set_ftrace_filter
echo $1
- exit -1
+ exit 255
}
echo "Testing function tracer with profiler:"
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ftracetest: Don't use non-POSIX exit -1
2015-03-05 2:04 [PATCH] ftracetest: Don't use non-POSIX exit -1 Michael Ellerman
@ 2015-03-05 2:26 ` Steven Rostedt
2015-03-05 2:56 ` Michael Ellerman
2015-03-05 2:40 ` Masami Hiramatsu
1 sibling, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2015-03-05 2:26 UTC (permalink / raw)
To: Michael Ellerman; +Cc: shuahkh, linux-kernel, davej, namhyung
On Thu, 5 Mar 2015 13:04:02 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:
> POSIX says that exit takes an unsigned integer between 0 and 255.
>
> Convert exit -1 to exit 255.
>
Why 255? Why not just exit 1?
Actually, don't we have explicit numbers for exit status?
/me not looking at the code right now to figure that out.
-- Steve
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftracetest: Don't use non-POSIX exit -1
2015-03-05 2:26 ` Steven Rostedt
@ 2015-03-05 2:56 ` Michael Ellerman
2015-03-05 14:04 ` Steven Rostedt
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2015-03-05 2:56 UTC (permalink / raw)
To: Steven Rostedt; +Cc: shuahkh, linux-kernel, davej, namhyung
On Wed, 2015-03-04 at 21:26 -0500, Steven Rostedt wrote:
> On Thu, 5 Mar 2015 13:04:02 +1100
> Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> > POSIX says that exit takes an unsigned integer between 0 and 255.
> >
> > Convert exit -1 to exit 255.
> >
>
> Why 255? Why not just exit 1?
I was trying to emulate the current behaviour:
$ /bin/bash
$ exit -1
exit
$ echo $?
255
> Actually, don't we have explicit numbers for exit status?
>
> /me not looking at the code right now to figure that out.
Yeah looks like it, and some interesting signal handling tricks:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/ftrace/ftracetest#n123
I'll send a new version using "exit $FAIL" ?
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftracetest: Don't use non-POSIX exit -1
2015-03-05 2:56 ` Michael Ellerman
@ 2015-03-05 14:04 ` Steven Rostedt
0 siblings, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2015-03-05 14:04 UTC (permalink / raw)
To: Michael Ellerman; +Cc: shuahkh, linux-kernel, davej, namhyung
On Thu, 05 Mar 2015 13:56:02 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:
> > Why 255? Why not just exit 1?
>
> I was trying to emulate the current behaviour:
>
> $ /bin/bash
> $ exit -1
> exit
> $ echo $?
> 255
Understood.
>
> > Actually, don't we have explicit numbers for exit status?
> >
> > /me not looking at the code right now to figure that out.
>
> Yeah looks like it, and some interesting signal handling tricks:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/ftrace/ftracetest#n123
>
> I'll send a new version using "exit $FAIL" ?
Yep, I figured instead of keeping current behavior, we actually fix it
correctly.
Thanks,
-- Steve
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftracetest: Don't use non-POSIX exit -1
2015-03-05 2:04 [PATCH] ftracetest: Don't use non-POSIX exit -1 Michael Ellerman
2015-03-05 2:26 ` Steven Rostedt
@ 2015-03-05 2:40 ` Masami Hiramatsu
1 sibling, 0 replies; 5+ messages in thread
From: Masami Hiramatsu @ 2015-03-05 2:40 UTC (permalink / raw)
To: Michael Ellerman; +Cc: shuahkh, rostedt, linux-kernel, davej, namhyung
(2015/03/05 11:04), Michael Ellerman wrote:
> POSIX says that exit takes an unsigned integer between 0 and 255.
>
> Convert exit -1 to exit 255.
Good catch :)
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks!
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> tools/testing/selftests/ftrace/test.d/00basic/basic4.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc b/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc
> index fd9c49a13612..f6b9fc323ee0 100644
> --- a/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc
> +++ b/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc
> @@ -2,4 +2,4 @@
> # description: Basic event tracing check
> test -f available_events -a -f set_event -a -d events
> # check scheduler events are available
> -grep -q sched available_events && exit 0 || exit -1
> \ No newline at end of file
> +grep -q sched available_events && exit 0 || exit 255
> \ No newline at end of file
> diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> index 668616d9bb03..59a352408284 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> @@ -9,7 +9,7 @@ do_reset() {
> fail() { #msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> if [ ! -f set_event -o ! -d events/sched ]; then
> diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> index 655c415b6e7f..1e4dbf06d690 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> @@ -9,7 +9,7 @@ do_reset() {
> fail() { #msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> if [ ! -f set_event -o ! -d events/sched ]; then
> diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> index 480845774007..6b6a12cba387 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> @@ -9,7 +9,7 @@ do_reset() {
> fail() { #msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> if [ ! -f available_events -o ! -f set_event -o ! -d events ]; then
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
> index c15e018e0220..7320344072ec 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
> @@ -25,7 +25,7 @@ do_reset() {
> fail() { # msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> disable_tracing
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
> index 6af5f6360b18..9f63b8081f7c 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
> @@ -17,7 +17,7 @@ do_reset() {
> fail() { # msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> disable_tracing
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
> index 2e719cb1fc4d..e01ea0a9764e 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
> @@ -31,7 +31,7 @@ fail() { # mesg
> reset_tracer
> echo > set_ftrace_filter
> echo $1
> - exit -1
> + exit 255
> }
>
> echo "Testing function tracer with profiler:"
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-05 14:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-05 2:04 [PATCH] ftracetest: Don't use non-POSIX exit -1 Michael Ellerman
2015-03-05 2:26 ` Steven Rostedt
2015-03-05 2:56 ` Michael Ellerman
2015-03-05 14:04 ` Steven Rostedt
2015-03-05 2:40 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox