Re: [PATCH v2 3/7] zsmalloc: support compaction

Minchan Kim
2015-03-09T00:05:20Z

Hello Heesub,

On Thu, Mar 05, 2015 at 02:18:17PM +0900, Heesub Shin wrote:
> Hello Minchan,
>
> Nice work!

Thanks. :)

>
> On 03/04/2015 02:01 PM, Minchan Kim wrote:
> > +static void putback_zspage(struct zs_pool *pool, struct size_class *class,
> > + struct page *first_page)
> > +{
> > + int class_idx;
> > + enum fullness_group fullness;
> > +
> > + BUG_ON(!is_first_page(first_page));
> > +
> > + get_zspage_mapping(first_page, &class_idx, &fullness);
> > + insert_zspage(first_page, class, fullness);
> > + fullness = fix_fullness_group(class, first_page);
>
> Removal and re-insertion of zspage above can be eliminated, like this:
>
> fullness = get_fullness_group(first_page);
> insert_zspage(first_page, class, fullness);
> set_zspage_mapping(first_page, class->index, fullness);

True.

Thanks for the review!

--
Kind regards,
Minchan Kim