From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754811AbbCEJAv (ORCPT ); Thu, 5 Mar 2015 04:00:51 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:40206 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754799AbbCEJAt (ORCPT ); Thu, 5 Mar 2015 04:00:49 -0500 Message-ID: <54F81B37.6000609@st.com> Date: Thu, 5 Mar 2015 10:00:39 +0100 From: Gabriel Fernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Axel Lin , Kishon Vijay Abraham I CC: "kernel@vger.kernel.org" , Alexandre Torgue Subject: Re: [PATCH 2/2] phy: miphy28lp: Use PTR_ERR_OR_ZERO References: <1425519789.1637.4.camel@phoenix> <1425519846.1637.5.camel@phoenix> In-Reply-To: <1425519846.1637.5.camel@phoenix> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.254.186] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-03-05_03:2015-03-03,2015-03-05,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Gabriel Fernandez On 03/05/2015 02:44 AM, Axel Lin wrote: > PTR_ERR_OR_ZERO simplifies the code. > > Signed-off-by: Axel Lin > --- > drivers/phy/phy-miphy28lp.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c > index 9334352..c4cc11d 100644 > --- a/drivers/phy/phy-miphy28lp.c > +++ b/drivers/phy/phy-miphy28lp.c > @@ -1259,10 +1259,7 @@ static int miphy28lp_probe(struct platform_device *pdev) > } > > provider = devm_of_phy_provider_register(&pdev->dev, miphy28lp_xlate); > - if (IS_ERR(provider)) > - return PTR_ERR(provider); > - > - return 0; > + return PTR_ERR_OR_ZERO(provider); > } > > static const struct of_device_id miphy28lp_of_match[] = {