From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754817AbbCEJXo (ORCPT ); Thu, 5 Mar 2015 04:23:44 -0500 Received: from service87.mimecast.com ([91.220.42.44]:46474 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754384AbbCEJXk convert rfc822-to-8bit (ORCPT ); Thu, 5 Mar 2015 04:23:40 -0500 Message-ID: <54F820B5.7030503@arm.com> Date: Thu, 05 Mar 2015 09:24:05 +0000 From: Juri Lelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Wanpeng Li , Ingo Molnar , Peter Zijlstra CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] sched/deadline: don't need to check throttled status when switched to dl References: <1424923864-3001-1-git-send-email-wanpeng.li@linux.intel.com> <20150305013812.GA2966@kernel> In-Reply-To: <20150305013812.GA2966@kernel> X-OriginalArrivalTime: 05 Mar 2015 09:23:37.0695 (UTC) FILETIME=[0FAA7EF0:01D05726] X-MC-Unique: 115030509233802301 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/15 01:38, Wanpeng Li wrote: > Ping Juri, Yeah, I looked at it this morning. Looks good, thanks! > On Thu, Feb 26, 2015 at 12:11:04PM +0800, Wanpeng Li wrote: >> After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter >> modification handling"), deadline task throttled status is cleared >> each time switch from dl, so throttled status always unset when >> switch back, there is no need to check throttled status, this patch >> drop the check. >> >> Signed-off-by: Wanpeng Li Acked-by: Juri Lelli >> --- >> kernel/sched/deadline.c | 8 -------- >> 1 file changed, 8 deletions(-) >> >> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c >> index ca391c0..cfb8fa7 100644 >> --- a/kernel/sched/deadline.c >> +++ b/kernel/sched/deadline.c >> @@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) >> { >> int check_resched = 1; >> >> - /* >> - * If p is throttled, don't consider the possibility >> - * of preempting rq->curr, the check will be done right >> - * after its runtime will get replenished. >> - */ >> - if (unlikely(p->dl.dl_throttled)) >> - return; >> - >> if (task_on_rq_queued(p) && rq->curr != p) { >> #ifdef CONFIG_SMP >> if (p->nr_cpus_allowed > 1 && rq->dl.overloaded && >> -- >> 1.9.1 >