From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754857AbbCEJ2y (ORCPT ); Thu, 5 Mar 2015 04:28:54 -0500 Received: from service87.mimecast.com ([91.220.42.44]:57882 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754378AbbCEJ2w convert rfc822-to-8bit (ORCPT ); Thu, 5 Mar 2015 04:28:52 -0500 Message-ID: <54F821D8.4030605@arm.com> Date: Thu, 05 Mar 2015 09:28:56 +0000 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Borislav Petkov CC: Sudeep Holla , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andre Przywara , "x86@kernel.org" Subject: Re: [PATCH v3] x86: move cacheinfo sysfs to generic cacheinfo infrastructure References: <1424715265-21407-1-git-send-email-sudeep.holla@arm.com> <1425470416-20691-1-git-send-email-sudeep.holla@arm.com> <20150304122720.GD3663@pd.tnic> <20150305081640.GA3817@pd.tnic> In-Reply-To: <20150305081640.GA3817@pd.tnic> X-OriginalArrivalTime: 05 Mar 2015 09:28:48.0328 (UTC) FILETIME=[C8D15480:01D05726] X-MC-Unique: 115030509285000401 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 05/03/15 08:16, Borislav Petkov wrote: > On Wed, Mar 04, 2015 at 01:27:20PM +0100, Borislav Petkov wrote: >> Applied, thanks guys. > > Ok, we forgot to add the same check in the cpu_has_topoext case in > __cache_amd_cpumap_setup() and my F15h exploded this morning: > > --- > diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c > index 54e43d58e714..8008bc2dd2d0 100644 > --- a/arch/x86/kernel/cpu/intel_cacheinfo.c > +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c > @@ -820,9 +820,13 @@ static int __cache_amd_cpumap_setup(unsigned int cpu, int index, > > for_each_online_cpu(i) { > this_cpu_ci = get_cpu_cacheinfo(i); > + if (!this_cpu_ci->info_list) > + continue; > + > apicid = cpu_data(i).apicid; > if ((apicid < first) || (apicid > last)) > continue; > + > this_leaf = this_cpu_ci->info_list + index; > > for_each_online_cpu(sibling) { > --- > > I've folded the above into your patch. > Thanks a lot. -- Regards, Sudeep