[ulf.hansson-mmc:next 1/17] drivers/mmc/host/dw_mmc-exynos.c:480:5: sparse: symbol 'dw_mci_exynos_prepare_hs400_tuning' was not declared. Should it be static?

[ulf.hansson-mmc:next 1/17] drivers/mmc/host/dw_mmc-exynos.c:480:5: sparse: symbol 'dw_mci_exynos_prepare_hs400_tuning' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.linaro.org/people/ulf.hansson/mmc next
head:   cc92508d8a444000ec259debaf7603faf77540de
commit: 880e5e640a1f39802da76d9570bed2d8456f302a [1/17] mmc: dw_mmc: exynos: Support eMMC's HS400 mode
reproduce:
  # apt-get install sparse
  git checkout 880e5e640a1f39802da76d9570bed2d8456f302a
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/mmc/host/dw_mmc-exynos.c:480:5: sparse: symbol 'dw_mci_exynos_prepare_hs400_tuning' was not declared. Should it be static?
--
>> drivers/mmc/host/dw_mmc.c:1327:5: sparse: symbol 'dw_mci_prepare_hs400_tuning' was not declared. Should it be static?
   drivers/mmc/host/dw_mmc.c:2913:1: sparse: symbol '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally initialized at drivers/mmc/host/dw_mmc.c:2912)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH ulf.hansson-mmc] mmc: dw_mmc: exynos: dw_mci_exynos_prepare_hs400_tuning() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 dw_mmc-exynos.c |    2 +-
 dw_mmc.c        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 0a56d766..e761eb1 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -477,7 +477,7 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot)
 	return ret;
 }
 
-int dw_mci_exynos_prepare_hs400_tuning(struct dw_mci *host,
+static int dw_mci_exynos_prepare_hs400_tuning(struct dw_mci *host,
 					struct mmc_ios *ios)
 {
 	struct dw_mci_exynos_priv_data *priv = host->priv;
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index f30ef69..a99fa1b 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1324,7 +1324,7 @@ static int dw_mci_execute_tuning(struct mmc_host *mmc, u32 opcode)
 	return err;
 }
 
-int dw_mci_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios)
+static int dw_mci_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios)
 {
 	struct dw_mci_slot *slot = mmc_priv(mmc);
 	struct dw_mci *host = slot->host;

Re: [PATCH ulf.hansson-mmc] mmc: dw_mmc: exynos: dw_mci_exynos_prepare_hs400_tuning() can be static

[Jaehoon Chung]

Hi,

Sorry for missing warning, and Thanks for pointing out.

Best Regards,
Jaehoon Chung


On 03/05/2015 07:02 PM, kbuild test robot wrote:
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  dw_mmc-exynos.c |    2 +-
>  dw_mmc.c        |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 0a56d766..e761eb1 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -477,7 +477,7 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot)
>  	return ret;
>  }
>  
> -int dw_mci_exynos_prepare_hs400_tuning(struct dw_mci *host,
> +static int dw_mci_exynos_prepare_hs400_tuning(struct dw_mci *host,
>  					struct mmc_ios *ios)
>  {
>  	struct dw_mci_exynos_priv_data *priv = host->priv;
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index f30ef69..a99fa1b 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1324,7 +1324,7 @@ static int dw_mci_execute_tuning(struct mmc_host *mmc, u32 opcode)
>  	return err;
>  }
>  
> -int dw_mci_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios)
> +static int dw_mci_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios)
>  {
>  	struct dw_mci_slot *slot = mmc_priv(mmc);
>  	struct dw_mci *host = slot->host;
>