From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932486AbbCEKPy (ORCPT ); Thu, 5 Mar 2015 05:15:54 -0500 Received: from mail.kapsi.fi ([217.30.184.167]:38678 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932156AbbCEKPv (ORCPT ); Thu, 5 Mar 2015 05:15:51 -0500 Message-ID: <54F82CAE.7070300@kapsi.fi> Date: Thu, 05 Mar 2015 12:15:10 +0200 From: Mikko Perttunen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Tuomas Tynkkynen CC: Paul Bolle , swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, pdeschrijver@nvidia.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, mturquette@linaro.org, pwalmsley@nvidia.com, vinceh@nvidia.com, pgaikwad@nvidia.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tuomas Tynkkynen Subject: Re: [PATCH v8 15/18] cpufreq: Add cpufreq driver for Tegra124 References: <1425213881-5262-1-git-send-email-mikko.perttunen@kapsi.fi> <1425213881-5262-16-git-send-email-mikko.perttunen@kapsi.fi> <1425286186.24292.76.camel@x220> <54F59C16.2010401@kapsi.fi> <54F6B03F.8080703@iki.fi> In-Reply-To: <54F6B03F.8080703@iki.fi> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:708:30:12d0:beee:7bff:fe5b:f272 X-SA-Exim-Mail-From: mikko.perttunen@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2015 09:11 AM, Tuomas Tynkkynen wrote: > On 03/03/2015 01:33 PM, Mikko Perttunen wrote: >> On 03/02/2015 10:49 AM, Paul Bolle wrote: >>> On Sun, 2015-03-01 at 14:44 +0200, Mikko Perttunen wrote: >>> >>> [...] >>> >>>> +static struct platform_driver tegra124_cpufreq_platdrv = { >>>> + .driver = { >>>> + .name = "cpufreq-tegra124", >>>> + .owner = THIS_MODULE, >>> >>> .owner will always be, in short, NULL. >>> > > Which reminds me: recently there have been cleanups that remove the > .owner field assignments (e.g. 30f51f248c1d "cpufreq: drop owner > assignment from platform_drivers"), so it can be removed from here as well. > > >> >> Well noticed! I changed the config symbol to be tristate. >> >> Thanks, >> Mikko Perttunen >> Yep, will remove. Mikko