From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755282AbbCELW5 (ORCPT ); Thu, 5 Mar 2015 06:22:57 -0500 Received: from foss.arm.com ([217.140.101.70]:56691 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbbCELWz (ORCPT ); Thu, 5 Mar 2015 06:22:55 -0500 Message-ID: <54F83C8C.3060305@arm.com> Date: Thu, 05 Mar 2015 11:22:52 +0000 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Yun Wu , "tglx@linutronix.de" , "jason@lakedaemon.net" CC: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 3/5] irqchip: gicv3-its: add limitation to page order References: <1425439098-10708-1-git-send-email-wuyun.wu@huawei.com> <1425439098-10708-4-git-send-email-wuyun.wu@huawei.com> In-Reply-To: <1425439098-10708-4-git-send-email-wuyun.wu@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/15 03:18, Yun Wu wrote: > When required size of Device Table is out of the page allocator's > capability, the whole ITS will fail in probing. This actually is > not the hardware's problem and is mainly a limitation of the kernel > page allocator. This patch will keep ITS going on to the next > initializaion stage with an explicit warning. > > Signed-off-by: Yun Wu > --- > drivers/irqchip/irq-gic-v3-its.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index f5bfa42..e8bda0b 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -828,6 +828,11 @@ static int its_alloc_tables(struct its_node *its) > u32 ids = GITS_TYPER_DEVBITS(typer); > > order = get_order((1UL << ids) * entry_size); > + if (order >= MAX_ORDER) { > + order = MAX_ORDER - 1; > + pr_warn("%s: DT size too large, reduce page order to %u\n", Please spell out device table instead of DT. Most people will interpret DT as Device Tree, and won't immediately get what is happening. Thanks, M. -- Jazz is not dead. It just smells funny...