Re: [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC

[Marc Zyngier <marc.zyngier@arm.com>]

Hi Michal,

On 05/03/15 13:53, Michal Simek wrote:
> Initial version of device tree for Xilinx ZynqMP SoC.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
> ---
> 
> Changes in v2:
> -  move timer out of amba_apu bus because it is not on bus
>    Reported by Mark
> - FIC GICC and GICV addresses - Reported by Rob
> - Fix copyright
> - Enable cadence IP in defconfig
> - Add support for macb multiqueue
> 
>  arch/arm64/Kconfig                          |   5 +
>  arch/arm64/boot/dts/Makefile                |   1 +
>  arch/arm64/boot/dts/xilinx/Makefile         |   5 +
>  arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts |  47 +++++
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi      | 303 ++++++++++++++++++++++++++++
>  arch/arm64/configs/defconfig                |   3 +
>  6 files changed, 364 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/xilinx/Makefile
>  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
>  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp.dtsi

[...]

> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> new file mode 100644
> index 000000000000..0a3f40ecd06d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts

[...]

> +		gic: interrupt-controller@f9010000 {
> +			compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
> +			#interrupt-cells = <3>;
> +			reg = <0x0 0xf9010000 0x10000>,
> +			      <0x0 0xf902f000 0x2000>,
> +			      <0x0 0xf9040000 0x20000>,
> +			      <0x0 0xf906f000 0x2000>;
> +			interrupt-controller;

Please add the missing GIC maintenance interrupt.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...