From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755834AbbCEOF5 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Mar 2015 09:05:57 -0500
Received: from foss.arm.com ([217.140.101.70]:57301 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755794AbbCEOF4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Mar 2015 09:05:56 -0500
Message-ID: <54F862BE.7000901@arm.com>
Date: Thu, 05 Mar 2015 14:05:50 +0000
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: Michal Simek <michal.simek@xilinx.com>,
        linux-arm-kernel@lists.infradead.org,
        Mark Rutland <mark.rutland@arm.com>,
        Rob Herring <robherring2@gmail.com>
CC: devicetree@vger.kernel.org, Zach Pfeffer <zachp@xilinx.com>,
        Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Mark Brown <broonie@linaro.org>, Will Deacon <will.deacon@arm.com>,
        linux-kernel@vger.kernel.org, Robert Richter <rrichter@cavium.com>,
        Rob Herring <robh+dt@kernel.org>, Kumar Gala <galak@codeaurora.org>,
        Eddie Huang <eddie.huang@mediatek.com>,
        =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC
References: <cd616fa25dafee38f98e3b207e74450c5403f440.1425563597.git.michal.simek@xilinx.com>
In-Reply-To: <cd616fa25dafee38f98e3b207e74450c5403f440.1425563597.git.michal.simek@xilinx.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michal,

On 05/03/15 13:53, Michal Simek wrote:
> Initial version of device tree for Xilinx ZynqMP SoC.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
> ---
> 
> Changes in v2:
> -  move timer out of amba_apu bus because it is not on bus
>    Reported by Mark
> - FIC GICC and GICV addresses - Reported by Rob
> - Fix copyright
> - Enable cadence IP in defconfig
> - Add support for macb multiqueue
> 
>  arch/arm64/Kconfig                          |   5 +
>  arch/arm64/boot/dts/Makefile                |   1 +
>  arch/arm64/boot/dts/xilinx/Makefile         |   5 +
>  arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts |  47 +++++
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi      | 303 ++++++++++++++++++++++++++++
>  arch/arm64/configs/defconfig                |   3 +
>  6 files changed, 364 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/xilinx/Makefile
>  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
>  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp.dtsi

[...]

> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> new file mode 100644
> index 000000000000..0a3f40ecd06d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts

[...]

> +		gic: interrupt-controller@f9010000 {
> +			compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
> +			#interrupt-cells = <3>;
> +			reg = <0x0 0xf9010000 0x10000>,
> +			      <0x0 0xf902f000 0x2000>,
> +			      <0x0 0xf9040000 0x20000>,
> +			      <0x0 0xf906f000 0x2000>;
> +			interrupt-controller;

Please add the missing GIC maintenance interrupt.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...