From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758030AbbCERNf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Mar 2015 12:13:35 -0500
Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:31975 "EHLO
	mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757757AbbCERNc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Mar 2015 12:13:32 -0500
X-IronPort-AV: E=Sophos;i="5.11,348,1422950400"; 
   d="scan'208";a="58688633"
Message-ID: <54F88EB8.3020208@broadcom.com>
Date: Thu, 5 Mar 2015 09:13:28 -0800
From: Ray Jui <rjui@broadcom.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Paul Bolle <pebolle@tiscali.nl>
CC: Linus Walleij <linus.walleij@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        "Kumar Gala" <galak@codeaurora.org>,
        Grant Likely <grant.likely@linaro.org>,
        Christian Daudt <bcm@fixthebug.org>, Matt Porter <mporter@linaro.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Russell King <linux@arm.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
        Scott Branden <sbranden@broadcom.com>,
        Dmitry Torokhov <dtor@google.com>, Anatol Pomazau <anatol@google.com>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-gpio@vger.kernel.org>, <bcm-kernel-feedback-list@broadcom.com>,
        <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver
References: <1425515756-321-1-git-send-email-rjui@broadcom.com>	 <1425515756-321-7-git-send-email-rjui@broadcom.com>	 <1425543104.24292.185.camel@x220> <1425544581.24292.194.camel@x220>
In-Reply-To: <1425544581.24292.194.camel@x220>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Paul,

On 3/5/2015 12:36 AM, Paul Bolle wrote:
> On Thu, 2015-03-05 at 09:11 +0100, Paul Bolle wrote:
>> On Wed, 2015-03-04 at 16:35 -0800, Ray Jui wrote:
>>> +MODULE_AUTHOR("Ray Jui <rjui@broadcom.com>");
>>> +MODULE_DESCRIPTION("Broadcom Cygnus GPIO Driver");
>>> +MODULE_LICENSE("GPL v2");
>>
>> These three macros will be preprocessed away. (There's also
>> MODULE_DEVICE_TABLE. I don't yet know how that is handled in a
>> non-modular build, sorry.)
> 
> It turns out MODULE_DEVICE_TABLE is _really_ preprocessed away. See
> include/linux/module.h:
>     #ifdef MODULE
>     /* Creates an alias so file2alias.c can find device table. */
>     #define MODULE_DEVICE_TABLE(type, name)                                 \
>     extern const typeof(name) __mod_##type##__##name##_device_table         \
>       __attribute__ ((unused, alias(__stringify(name))))
>     #else  /* !MODULE */
>     #define MODULE_DEVICE_TABLE(type, name)
>     #endif
> 
> 
> Did I get that right?
> 
> (I knew the other three MODULE_* macros are handled in slightly more
> complicated way, but the effect is basically that they are preprocessed
> away.)
> 
> 
> Paul Bolle
> 

Even these module macros will be pre-processed away when the driver is
statically linked (and yes, I'm not planning to ever make these driver
built as module), I'm not too sure about the convention here. I thought
that they are still good to be in the driver for information purpose.
I'm seeing other pinctrl drivers doing this as well.

Maybe Linus can help to clarify this?

Thanks,

Ray