Re: [PATCH 2/2] toshiba_acpi: Add Satellite P50W-B to alternative keymap and create new mappings.

[Joseph Salisbury <joseph.salisbury@canonical.com>]

On 03/05/2015 04:04 PM, Azael Avalos wrote:
> Hi Joe,
>
> 2015-03-05 13:59 GMT-07:00 Joseph Salisbury <joseph.salisbury@canonical.com>:
>> On 03/04/2015 07:05 PM, Azael Avalos wrote:
>>> Hi there,
>>>
>>> 2015-03-04 14:52 GMT-07:00 Joseph Salisbury <joseph.salisbury@canonical.com>:
>>> ...
>>>> +       { KE_KEY, 0x140, { KEY_BRIGHTNESSDOWN } },
>>>> +       { KE_KEY, 0x141, { KEY_BRIGHTNESSUP } },
>>> ...
>>>
>>> These two are not neccesary, as they may collide with "previous song"
>>> and "playpause" in case Toshiba (or its manufacturers) decide to use
>>> those keys.
>>>
>>> If you can, please test the first two patches from the gmane archive [1],
>>> they eliminate the need of the DMI matching list. And it would be great
>>> to have more laptops tested.
>>>
>>> [1] http://comments.gmane.org/gmane.linux.drivers.platform.x86.devel/6602
>>>
>>>
>>> Cheers
>>> Azael
>>>
>>>
>> Hi Azael,
>>
>> There is some positive feedback with the first two patches:
>> toshiba_acpi: Add Hotkey Event Type function and definitions
>> toshiba_acpi: Use the Hotkey Event Type function for keymap choosing
>>
>> $ uname -r
>> 4.0.0-040000rc2-generic
>> $ acpi_listen
>> video/brightnessdown BRTDN 00000087 00000000
>> video/brightnessup BRTUP 00000086 00000000
>> video/switchmode VMOD 00000080 00000000 K
>> cd/prev CDPREV 00000080 00000000 K
>> cd/play CDPLAY 00000080 00000000 K
>> cd/next CDNEXT 00000080 00000000 K
>> button/volumedown VOLDN 00000080 00000000 K
>> button/volumeup VOLUP 00000080 00000000 K
>> button/mute MUTE 00000080 00000000 K
>> button/mute MUTE 00000080 00000000 K
>> button/wlan WLAN 00000080 00000000 K
>> button/volumedown VOLDN 00000080 00000000 K
>> button/volumeup VOLUP 00000080 00000000 K
>>
>>
>>
>> Can you also cc this patch to stable when submitting it to mainline?
> Right now I'm conducting some tests with the help
> of Tom Mannerhagen as he has access to more
> laptops, so I will probably need to send an updated
> revision of the series.

Thanks for the great work, Azael.  More than glad to assist with the
testing.

>
> But will do once we have those tests results and patches ready.
>
>> All the keys are working and the patch is allot cleaner!
>>
>> Thanks again,
> Ohh, and thanks to you too for testing.
>
>> Joe
>>
> Cheers
> Azael
>
>