From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754826AbbCFIgJ (ORCPT ); Fri, 6 Mar 2015 03:36:09 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:40121 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751747AbbCFIgG (ORCPT ); Fri, 6 Mar 2015 03:36:06 -0500 Message-ID: <54F966F1.4090900@linaro.org> Date: Fri, 06 Mar 2015 09:36:01 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Alexandre Belloni , Nicolas Ferre CC: Boris Brezillon , Jean-Christophe Plagniol-Villard , Thomas Gleixner , Lee Jones , Wim Van Sebroeck , Guenter Roeck , Sebastian Reichel , Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v4 6/9] ARM: at91: time: move the system timer driver to drivers/clocksource References: <1425570594-13124-1-git-send-email-alexandre.belloni@free-electrons.com> <1425570594-13124-7-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1425570594-13124-7-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2015 04:49 PM, Alexandre Belloni wrote: > Import at91rm9200_time.c from mach-at91 as timer-atmel-st.c. Further cleanup is > required to get rid of the mach-at91 headers. > > Signed-off-by: Alexandre Belloni > Acked-by: Boris Brezillon > --- > arch/arm/mach-at91/Makefile | 2 +- > drivers/clocksource/Kconfig | 4 ++++ > drivers/clocksource/Makefile | 1 + > .../at91rm9200_time.c => drivers/clocksource/timer-atmel-st.c | 0 > 4 files changed, 6 insertions(+), 1 deletion(-) > rename arch/arm/mach-at91/at91rm9200_time.c => drivers/clocksource/timer-atmel-st.c (100%) > > diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile > index 827fdbcce1c7..963c29169242 100644 > --- a/arch/arm/mach-at91/Makefile > +++ b/arch/arm/mach-at91/Makefile > @@ -7,7 +7,7 @@ obj-y := setup.o > obj-$(CONFIG_SOC_AT91SAM9) += sam9_smc.o > > # CPU-specific support > -obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o at91rm9200_time.o > +obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o > obj-$(CONFIG_SOC_AT91SAM9) += at91sam9.o > obj-$(CONFIG_SOC_SAMA5) += sama5.o > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 1c2506f68122..d1d15985a4ec 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -138,6 +138,10 @@ config ATMEL_PIT > select CLKSRC_OF if OF > def_bool SOC_AT91SAM9 || SOC_SAMA5 > > +config ATMEL_ST > + select CLKSRC_OF if OF > + def_bool SOC_AT91RM9200 > + H Alexandre, the global policy is to enable the timer from the platform Kconfig. So it should be: config ATMEL_ST bool select CLKSRC_OF if OF and change the mach's Kconfig to select this driver for the corresponding platform. > config CLKSRC_METAG_GENERIC > def_bool y if METAG > help > diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile > index 752d5c70b0ef..5b85f6adb258 100644 > --- a/drivers/clocksource/Makefile > +++ b/drivers/clocksource/Makefile > @@ -1,5 +1,6 @@ > obj-$(CONFIG_CLKSRC_OF) += clksrc-of.o > obj-$(CONFIG_ATMEL_PIT) += timer-atmel-pit.o > +obj-$(CONFIG_ATMEL_ST) += timer-atmel-st.o > obj-$(CONFIG_ATMEL_TCB_CLKSRC) += tcb_clksrc.o > obj-$(CONFIG_X86_PM_TIMER) += acpi_pm.o > obj-$(CONFIG_SCx200HR_TIMER) += scx200_hrt.o > diff --git a/arch/arm/mach-at91/at91rm9200_time.c b/drivers/clocksource/timer-atmel-st.c > similarity index 100% > rename from arch/arm/mach-at91/at91rm9200_time.c > rename to drivers/clocksource/timer-atmel-st.c > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog