From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754744AbbCFJjw (ORCPT ); Fri, 6 Mar 2015 04:39:52 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:30685 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbbCFJjs (ORCPT ); Fri, 6 Mar 2015 04:39:48 -0500 Message-ID: <54F975D4.9020503@huawei.com> Date: Fri, 6 Mar 2015 17:39:32 +0800 From: "Chentao (Boby)" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: David Vrabel , , , CC: , , , , Subject: Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK References: <1425493951-41801-1-git-send-email-boby.chen@huawei.com> <54F6DFB7.2080402@citrix.com> In-Reply-To: <54F6DFB7.2080402@citrix.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.25.98] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/4 18:34, David Vrabel wrote: > On 04/03/15 18:32, Tao Chen wrote: >> Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. >> Also fixed up some comments just as eliminate redundant white spaces and format the code. >> These will make the code easier to read. > > I have already said you needed to use: > > #define pr_fmt(fmt) > > to do this. > > David > > . > David, I'm sorry because I didn't read your reply in time. I will accept your advice in my next patch. Many thanks to you.