public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Vignesh R <vigneshr@ti.com>, Felipe Balbi <balbi@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] phy: omap-control: Remove unneeded ifdef CONFIG_OF guard and of_match_ptr
Date: Fri, 6 Mar 2015 12:06:00 +0200	[thread overview]
Message-ID: <54F97C08.1060106@ti.com> (raw)
In-Reply-To: <CAFRkauD6gXfuaGoopF-B+e1KLEi64XdWprus7nA6wx8nhki6zA@mail.gmail.com>

On 05/03/15 17:29, Axel Lin wrote:
> 2015-03-05 18:48 GMT+08:00 Roger Quadros <rogerq@ti.com>:
>> Hi Alex,
> It's Axel.

My apologies Axel.

> 
>>
>> Since we're anyways going to fail probe for !CONFIG_OF, why do you want to
>> add the unnecessary device table to the kernel?
>>
>> what are you benefiting from this change?
> 
> If the driver works for both dt case and non-dt case, using the ifdef CONFIG_OF
> guard can save a few memory for non-dt case.
> For dt-only  driver it is not required because you cannot use the driver
> if !CONFIG_OF. Which means you should not build this driver at all if !CONFIG_OF
> unless you just want to do compile test.

I agree. Kishon do we really need to build these drivers if !CONFIG_OF?

cheers,
-roger

  reply	other threads:[~2015-03-06 10:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05 10:18 [PATCH 1/3] phy: omap-control: Remove unneeded ifdef CONFIG_OF guard and of_match_ptr Axel Lin
2015-03-05 10:20 ` [PATCH 2/3] phy: omap-usb2: " Axel Lin
2015-03-05 10:20 ` [PATCH 3/3] phy: ti-pipe3: " Axel Lin
2015-03-05 10:48 ` [PATCH 1/3] phy: omap-control: " Roger Quadros
2015-03-05 15:29   ` Axel Lin
2015-03-06 10:06     ` Roger Quadros [this message]
2015-03-09  5:11       ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F97C08.1060106@ti.com \
    --to=rogerq@ti.com \
    --cc=axel.lin@ingics.com \
    --cc=balbi@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox