From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933554AbbCFKGS (ORCPT ); Fri, 6 Mar 2015 05:06:18 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:53499 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932309AbbCFKGG (ORCPT ); Fri, 6 Mar 2015 05:06:06 -0500 Message-ID: <54F97C08.1060106@ti.com> Date: Fri, 6 Mar 2015 12:06:00 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Axel Lin CC: Kishon Vijay Abraham I , Vignesh R , Felipe Balbi , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] phy: omap-control: Remove unneeded ifdef CONFIG_OF guard and of_match_ptr References: <1425550725.21331.1.camel@phoenix> <54F83492.5080103@ti.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/15 17:29, Axel Lin wrote: > 2015-03-05 18:48 GMT+08:00 Roger Quadros : >> Hi Alex, > It's Axel. My apologies Axel. > >> >> Since we're anyways going to fail probe for !CONFIG_OF, why do you want to >> add the unnecessary device table to the kernel? >> >> what are you benefiting from this change? > > If the driver works for both dt case and non-dt case, using the ifdef CONFIG_OF > guard can save a few memory for non-dt case. > For dt-only driver it is not required because you cannot use the driver > if !CONFIG_OF. Which means you should not build this driver at all if !CONFIG_OF > unless you just want to do compile test. I agree. Kishon do we really need to build these drivers if !CONFIG_OF? cheers, -roger