From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754055AbbCFNSh (ORCPT ); Fri, 6 Mar 2015 08:18:37 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:56357 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbbCFNSd (ORCPT ); Fri, 6 Mar 2015 08:18:33 -0500 X-IronPort-AV: E=Sophos;i="5.11,352,1422921600"; d="scan'208";a="242456748" Message-ID: <54F9A926.3060108@citrix.com> Date: Fri, 6 Mar 2015 13:18:30 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Juergen Gross , , , , , Subject: Re: [Xen-devel] [PATCH] xen: avoid NULL pointer dereference in dom0 on large machines References: <1424929925-18501-1-git-send-email-jgross@suse.com> In-Reply-To: <1424929925-18501-1-git-send-email-jgross@suse.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/02/15 05:52, Juergen Gross wrote: > Using the pvops kernel a NULL pointer dereference was detected on a > large machine (144 processors) when booting as dom0 in > evtchn_fifo_unmask() during assignment of a pirq. > > The event channel in question was the first to need a new entry in > event_array[] in events_fifo.c. Unfortunately xen_irq_info_pirq_setup() > is called with evtchn being 0 for a new pirq and the real event channel > number is assigned to the pirq only during __startup_pirq(). > > It is mandatory to call xen_evtchn_port_setup() after assigning the > event channel number to the pirq to make sure all memory needed for the > event channel is allocated. Applied to stable/for-linus-4.0 and tagged for stable, thanks. David