From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754687AbbCFOnK (ORCPT ); Fri, 6 Mar 2015 09:43:10 -0500 Received: from mail-ie0-f179.google.com ([209.85.223.179]:33306 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752927AbbCFOnH (ORCPT ); Fri, 6 Mar 2015 09:43:07 -0500 Message-ID: <54F9BCF3.1060609@linaro.org> Date: Fri, 06 Mar 2015 09:42:59 -0500 From: David Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Steve Capper CC: "linux-arm-kernel@lists.infradead.org" , Russell King , Sandeepa Prabhu , William Cohen , Catalin Marinas , Will Deacon , "Jon Medhurst (Tixy)" , Masami Hiramatsu , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , David Miller , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 4/6] arm64: kprobes instruction simulation support References: <1424214701-4899-1-git-send-email-dave.long@linaro.org> <1424214701-4899-5-git-send-email-dave.long@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/15 06:39, Steve Capper wrote: > On 17 February 2015 at 23:11, David Long wrote: >> From: Sandeepa Prabhu >> >> Kprobes needs simulation of instructions that cannot be stepped >> from different memory location, e.g.: those instructions >> that uses PC-relative addressing. In simulation, the behaviour >> of the instruction is implemented using a copy of pt_regs. >> >> Following instruction catagories are simulated: >> - All branching instructions(conditional, register, and immediate) >> - Literal access instructions(load-literal, adr/adrp) >> >> Conditional execution is limited to branching instructions in >> ARM v8. If conditions at PSTATE do not match the condition fields >> of opcode, the instruction is effectively NOP. Kprobes considers >> this case as 'miss'. >> >> Thanks to Will Cohen for assorted suggested changes. >> >> Signed-off-by: Sandeepa Prabhu >> Signed-off-by: William Cohen >> Signed-off-by: David A. Long >> --- > > Hi, > Apologies for looking at these late (I was on holiday). > > I've applied this series on top of 3.19, but I get the following compile error: > arch/arm64/kernel/kprobes-arm64.c:23:34: fatal error: > probes-simulate-insn.h: No such file or directory > #include "probes-simulate-insn.h" > ^ > compilation terminated. > scripts/Makefile.build:257: recipe for target > 'arch/arm64/kernel/kprobes-arm64.o' failed > > Is something missing from this patch? > > Cheers, > -- > Steve > Yes Steve, the patch is missing three new files. It passed my testing because I had not cleaned out non-checked-in files from my cloned repo. I've put a preliminary version of a v6 patch that addresses other feedback in my own public repo, and will send out a new patch in the near future after more testing and additional tweaks. -dl