From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756210AbbCFQsz (ORCPT ); Fri, 6 Mar 2015 11:48:55 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:54409 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900AbbCFQsx (ORCPT ); Fri, 6 Mar 2015 11:48:53 -0500 Message-ID: <54F9DA71.804@atmel.com> Date: Fri, 6 Mar 2015 17:48:49 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: , Michal Simek , CC: Punnaiah Choudary Kalluri , Subject: Re: [PATCH 1/2] net: macb: Include multi queue support for xilinx ZynqMP ethernet version References: <54F86171.3020700@monstr.eu> In-Reply-To: <54F86171.3020700@monstr.eu> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 05/03/2015 15:00, Michal Simek a écrit : > Hi Nicolas, > > On 03/05/2015 02:04 PM, Michal Simek wrote: >> From: Punnaiah Choudary Kalluri >> >> Include multi queue support for the ethernet IP version in xilinx ZynqMP >> SoC. >> >> Signed-off-by: Punnaiah Choudary Kalluri >> Signed-off-by: Michal Simek >> --- >> >> drivers/net/ethernet/cadence/macb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c >> index ad76b8e35a00..24b1eb466e52 100644 >> --- a/drivers/net/ethernet/cadence/macb.c >> +++ b/drivers/net/ethernet/cadence/macb.c >> @@ -2192,7 +2192,7 @@ static void macb_probe_queues(void __iomem *mem, >> >> /* is it macb or gem ? */ >> mid = __raw_readl(mem + MACB_MID); >> - if (MACB_BFEXT(IDNUM, mid) != 0x2) >> + if (MACB_BFEXT(IDNUM, mid) < 0x2) >> return; >> >> /* bit 0 is never set but queue 0 always exists */ >> > > Can you please check this? > (There will be definitely v2 because I forget to base it on net-next). Michal, It seems correct to me: you can add my: Acked-by: Nicolas Ferre Bye, -- Nicolas Ferre