From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754671AbbCGDUw (ORCPT ); Fri, 6 Mar 2015 22:20:52 -0500 Received: from down.free-electrons.com ([37.187.137.238]:42007 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754567AbbCGDUv (ORCPT ); Fri, 6 Mar 2015 22:20:51 -0500 Message-ID: <54FA6DFC.1070904@free-electrons.com> Date: Sat, 07 Mar 2015 00:18:20 -0300 From: Ezequiel Garcia User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Antoine Tenart , sebastian.hesselbarth@gmail.com, dwmw2@infradead.org, computersforpeace@gmail.com CC: boris.brezillon@free-electrons.com, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller References: <1425555085-29531-1-git-send-email-antoine.tenart@free-electrons.com> <1425555085-29531-6-git-send-email-antoine.tenart@free-electrons.com> In-Reply-To: <1425555085-29531-6-git-send-email-antoine.tenart@free-electrons.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Antoine, On 03/05/2015 08:31 AM, Antoine Tenart wrote: [..] > + > +static struct pxa3xx_nand_flash berlin_builtin_flash_types[] = { > +{ "4GiB 8-bit", 0xd7ec, 128, 8192, 8, 8, 4096 }, > +{ }, IMHO, supporting a specific flash shouldn't be part of this patch. In any case, why do you need this? If you can share the details about this device, it would be interesting for me to take a look. This driver's open-coded, legacy-style flash detection is nasty, and the only reason I've kept it is to avoid breaking some wacky user with some old board. In fact, maybe we can just kill it so nobody thinks it's sane. Flash detection is the NAND core's job, and duplicating it in the driver is not nice. Let's try to avoid it. BTW, nand_ids.c seems to list a similar device: EXTENDED_ID_NAND("NAND 4GiB 3,3V 8-bit", 0xD7, 4096, LP_OPTIONS), Have you tried this? -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com