From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751276AbbCGR2M (ORCPT ); Sat, 7 Mar 2015 12:28:12 -0500 Received: from mail-oi0-f51.google.com ([209.85.218.51]:39346 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbbCGR2H (ORCPT ); Sat, 7 Mar 2015 12:28:07 -0500 Message-ID: <54FB3523.7060600@lwfinger.net> Date: Sat, 07 Mar 2015 11:28:03 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Matteo Semenzato , gregkh@linuxfoundation.org, navin.patidar@gmail.com, oat.elena@gmail.com CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock References: <1425742407-6619-1-git-send-email-mattew8898@gmail.com> In-Reply-To: <1425742407-6619-1-git-send-email-mattew8898@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/2015 09:33 AM, Matteo Semenzato wrote: > From: Matteo Semenzato > > The rtw_cmd_thread semaphore was being unlocked twice. > > Signed-off-by: Matteo Semenzato > --- > drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c > index 4b43462..43a8515 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c > +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c > @@ -173,7 +173,7 @@ int rtw_cmd_thread(void *context) > allow_signal(SIGTERM); > > pcmdpriv->cmdthd_running = true; > - up(&pcmdpriv->terminate_cmdthread_sema); > + down(&pcmdpriv->terminate_cmdthread_sema); > > RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n")); I get nervous when I see patch 2/2 immediately resent as a single patch. What is going on? Have you actually tested this patch, or did you find this with some static checker? Larry