From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752762AbbCGU71 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Mar 2015 15:59:27 -0500
Received: from h1446028.stratoserver.net ([85.214.92.142]:37280 "EHLO
	mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751166AbbCGU7Z (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Mar 2015 15:59:25 -0500
Message-ID: <54FB669B.70400@ahsoftware.de>
Date: Sat, 07 Mar 2015 21:59:07 +0100
From: Alexander Holler <holler@ahsoftware.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Al Viro <viro@ZenIV.linux.org.uk>
CC: Alan Stern <stern@rowland.harvard.edu>,
        Richard Weinberger <richard.weinberger@gmail.com>,
        USB list <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, Felipe Balbi <balbi@ti.com>
Subject: Re: gadgetfs broken since 7f7f25e8
References: <Pine.LNX.4.44L0.1503041012400.1642-100000@iolanthe.rowland.org> <54FADFC2.1030302@ahsoftware.de> <54FB59A7.2080705@ahsoftware.de> <20150307205132.GD29656@ZenIV.linux.org.uk>
In-Reply-To: <20150307205132.GD29656@ZenIV.linux.org.uk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 07.03.2015 um 21:51 schrieb Al Viro:
> On Sat, Mar 07, 2015 at 09:03:51PM +0100, Alexander Holler wrote:
>> Am 07.03.2015 um 12:23 schrieb Alexander Holler:
>>> Am 04.03.2015 um 16:31 schrieb Alan Stern:
>>>
>>>> check to see what those values actually were.  It's easy enough to fix
>>>> up, though; revised patch below.
>>>
>>> Thanks, in contrast to the patch from Al Viro that one applies.
> 
> Translation: it applies to mainline as well as to vfs.git#gadget +
> ep_config_operations patch it's incremental to.
> 
>> And as I've just tested it, it isn't complete. ep_config_operations will
>> be switched to ep_io_operations and suffers under the same problem of
>> not having initially (aio_)read/(aio_)write since commit  7f7f25e8 (3.16).
> 
> Incremental patch does not deal with the problem handled by the patch
> it is incremental to, film at 11...
> 
> FWIW, patches in vfs.git#gadget are fixing fairly obvious bugs - leaks and
> use-after-free.
> 

Feel free to test it yourself.

Thansk for all the fish.