From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751057AbbCHAVU (ORCPT ); Sat, 7 Mar 2015 19:21:20 -0500 Received: from mail-qg0-f50.google.com ([209.85.192.50]:42904 "EHLO mail-qg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbbCHAVQ (ORCPT ); Sat, 7 Mar 2015 19:21:16 -0500 Message-ID: <54FB95FF.3060502@plumgrid.com> Date: Sat, 07 Mar 2015 16:21:19 -0800 From: Alexei Starovoitov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Steven Rostedt , Ingo Molnar CC: Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , "David S. Miller" , Daniel Borkmann , Peter Zijlstra , Linux API , Network Development , LKML Subject: Re: [PATCH v5 tip 0/7] tracing: attach eBPF programs to kprobes References: <1425252465-27527-1-git-send-email-ast@plumgrid.com> <20150304203316.GA7142@gmail.com> <20150304154824.5f165c6d@gandalf.local.home> <20150306200938.6a6387c0@gandalf.local.home> In-Reply-To: <20150306200938.6a6387c0@gandalf.local.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/6/15 5:09 PM, Steven Rostedt wrote: > On Wed, 4 Mar 2015 15:48:24 -0500 > Steven Rostedt wrote: > >> On Wed, 4 Mar 2015 21:33:16 +0100 >> Ingo Molnar wrote: >> >>> >>> * Alexei Starovoitov wrote: >>> >>>> On Sun, Mar 1, 2015 at 3:27 PM, Alexei Starovoitov wrote: >>>>> Peter, Steven, >>>>> I think this set addresses everything we've discussed. >>>>> Please review/ack. Thanks! >>>> >>>> icmp echo request >>> >>> I'd really like to have an Acked-by from Steve (propagated into the >>> changelogs) before looking at applying these patches. >> >> I'll have to look at this tomorrow. I'm a bit swamped with other things >> at the moment :-/ >> > > Just an update. I started looking at it but then was pulled off to do > other things. I'll make this a priority next week. Sorry for the delay. There is no rush. Please let me know if I need to clarify anything. One thing I just caught which I'm planning to address in the follow on patch is missing 'recursion check'. Since attaching programs to kprobes means that root may create loops by adding a kprobe somewhere in the call chain invoked from bpf program. So far I'm thinking to do simple stack_trace_call()-like check. I don't think it's a blocker for this set, but if I'm done coding recursion soon, I'll just roll it in and respin this set :)