From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbbCHM7W (ORCPT ); Sun, 8 Mar 2015 08:59:22 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:33887 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbbCHM7Q (ORCPT ); Sun, 8 Mar 2015 08:59:16 -0400 Message-ID: <54FC4797.6040704@gmail.com> Date: Sun, 08 Mar 2015 14:59:03 +0200 From: =?UTF-8?B?R2llZHJpdXMgU3RhdGtldmnEjWl1cw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Sudip Mukherjee , Greg Kroah-Hartman CC: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID References: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> <1425817886-14387-3-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1425817886-14387-3-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015.03.08 14:31, Sudip Mukherjee wrote: > check if it is already defined before defining SM750LE_REVISION_ID > again and at the same time mention correct data type. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/sm750fb/ddk750_chip.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h > index 1c78875..e7d27e8 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.h > +++ b/drivers/staging/sm750fb/ddk750_chip.h > @@ -1,7 +1,9 @@ > #ifndef DDK750_CHIP_H__ > #define DDK750_CHIP_H__ > #define DEFAULT_INPUT_CLOCK 14318181 /* Default reference clock */ > -#define SM750LE_REVISION_ID (char)0xfe > +#ifndef SM750LE_REVISION_ID > +#define SM750LE_REVISION_ID ((unsigned char)0xfe) > +#endif Do you need these parantheses? Also, you can now then fix up this line too to avoid a redundant cast in the same patch: sm750_hw.c: if(share->revid == (unsigned char)SM750LE_REVISION_ID){ -- Thanks, Giedrius