From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752801AbbCHNDC (ORCPT ); Sun, 8 Mar 2015 09:03:02 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:39851 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbbCHNC6 (ORCPT ); Sun, 8 Mar 2015 09:02:58 -0400 Message-ID: <54FC4875.1050800@gmail.com> Date: Sun, 08 Mar 2015 15:02:45 +0200 From: =?UTF-8?B?R2llZHJpdXMgU3RhdGtldmnEjWl1cw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Sudip Mukherjee , Greg Kroah-Hartman CC: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: sm750fb: fix undeclared function References: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> <1425817886-14387-4-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1425817886-14387-4-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015.03.08 14:31, Sudip Mukherjee wrote: > kbuild test robot reported that for microblaze-allyesconfig > chan_to_field() and lynxfb_ops_set_par() were not defined. These two > functions were defined under CONFIG_PM, so for any archtecture if > CONFIG_PM is not defined we will have this error. > while moving the lynxfb_suspend() function some very obvious > checkpatch errors were taken care of. Such as? If you do you could also fix up the poor things with that function too such as the comment style here (no space between ; and the comment): > + if (info) > + fb_set_suspend(info, 1);/* 1 means do suspend*/ > + or here (extra unneeded spaces): > + > + /* set chip to sleep mode */ > + if (share->suspend) > + (*share->suspend)(share); -- Thanks, Giedrius