From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753069AbbCHQXO (ORCPT ); Sun, 8 Mar 2015 12:23:14 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:47098 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672AbbCHQXK (ORCPT ); Sun, 8 Mar 2015 12:23:10 -0400 Message-ID: <54FC7769.7050306@lwfinger.net> Date: Sun, 08 Mar 2015 11:23:05 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mike Krinkin , gregkh@linuxfoundation.org CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: use %*ph specifier instead of passing direct values References: <1425830070-4948-1-git-send-email-krinkin.m.u@gmail.com> In-Reply-To: <1425830070-4948-1-git-send-email-krinkin.m.u@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2015 10:54 AM, Mike Krinkin wrote: > The %*ph specifier allows to pass a pointer and length instead of > pushing each byte via stack. The patch converts code to use it. > > Signed-off-by: Mike Krinkin Why not use %pM as long as you are changing this code? It will format the results in a better way. Larry > --- > drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c > index 122e9b3..960a7a5 100644 > --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c > +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c > @@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool > memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN); > } > RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, > - ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n", > - eeprom->mac_addr[0], eeprom->mac_addr[1], > - eeprom->mac_addr[2], eeprom->mac_addr[3], > - eeprom->mac_addr[4], eeprom->mac_addr[5])); > + ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n", > + eeprom->mac_addr)); > } > > static void >