[PATCH] staging: rtl8188eu: use %*ph specifier instead of passing direct values

[PATCH] staging: rtl8188eu: use %*ph specifier instead of passing direct values

[Mike Krinkin]

The %*ph specifier allows to pass a pointer and length instead of
pushing each byte via stack. The patch converts code to use it.

Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 122e9b3..960a7a5 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
 		memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
 	}
 	RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
-		 ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
-		 eeprom->mac_addr[0], eeprom->mac_addr[1],
-		 eeprom->mac_addr[2], eeprom->mac_addr[3],
-		 eeprom->mac_addr[4], eeprom->mac_addr[5]));
+		 ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n",
+		 eeprom->mac_addr));
 }
 
 static void
-- 
1.9.1

Re: [PATCH] staging: rtl8188eu: use %*ph specifier instead of passing direct values

[Larry Finger]

On 03/08/2015 10:54 AM, Mike Krinkin wrote:
> The %*ph specifier allows to pass a pointer and length instead of
> pushing each byte via stack. The patch converts code to use it.
>
> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>

Why not use %pM as long as you are changing this code? It will format the 
results in a better way.

Larry

> ---
>   drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index 122e9b3..960a7a5 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
>   		memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
>   	}
>   	RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
> -		 ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
> -		 eeprom->mac_addr[0], eeprom->mac_addr[1],
> -		 eeprom->mac_addr[2], eeprom->mac_addr[3],
> -		 eeprom->mac_addr[4], eeprom->mac_addr[5]));
> +		 ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n",
> +		 eeprom->mac_addr));
>   }
>
>   static void
>

Re: [PATCH] staging: rtl8188eu: use %*ph specifier instead of passing direct values

[Mike Krinkin]

On Sun, Mar 08, 2015 at 11:23:05AM -0500, Larry Finger wrote:
> On 03/08/2015 10:54 AM, Mike Krinkin wrote:
> >The %*ph specifier allows to pass a pointer and length instead of
> >pushing each byte via stack. The patch converts code to use it.
> >
> >Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
> 
> Why not use %pM as long as you are changing this code? It will
> format the results in a better way.
> 
> Larry

I just thought to save original formatting, but of course %pM is better,
i'll resend a new version.

> 
> >---
> >  drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> >diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> >index 122e9b3..960a7a5 100644
> >--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> >+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> >@@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
> >  		memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
> >  	}
> >  	RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
> >-		 ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
> >-		 eeprom->mac_addr[0], eeprom->mac_addr[1],
> >-		 eeprom->mac_addr[2], eeprom->mac_addr[3],
> >-		 eeprom->mac_addr[4], eeprom->mac_addr[5]));
> >+		 ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n",
> >+		 eeprom->mac_addr));
> >  }
> >
> >  static void
> >
>