From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753385AbbCICZw (ORCPT ); Sun, 8 Mar 2015 22:25:52 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:41343 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753349AbbCICZp (ORCPT ); Sun, 8 Mar 2015 22:25:45 -0400 Message-ID: <54FD0493.3000805@huawei.com> Date: Mon, 9 Mar 2015 10:25:23 +0800 From: "long.wanglong" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Rob Herring CC: Rob Herring , Gaurav Minocha , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Subject: Re: [PATCH] Documentation: update the of_selftest.txt References: <1425355008-56957-1-git-send-email-long.wanglong@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.88.174] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/6 22:40, Rob Herring wrote: > On Mon, Mar 2, 2015 at 9:56 PM, Wang Long wrote: >> Since the directory "drivers/of/testcase-data" is renamed >> to "drivers/of/unittest-data". so we should update the path >> in the of_selftest.txt. >> >> When the kernel is build with OF_SELFTEST enabled, the output > > s/build/built/ > > s/SELF/UNIT/ sorry for the mistakes. > >> dtb is testcases.dtb instead of testcase.dtb, also update it >> (s/testcase/testcases/). >> >> Signed-off-by: Wang Long >> --- >> Documentation/devicetree/of_selftest.txt | 22 +++++++++++----------- > > Please rename to of_unittest.txt as well and rename occurrences of > selftest to unittest. > > Rob OK > >> 1 file changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/Documentation/devicetree/of_selftest.txt b/Documentation/devicetree/of_selftest.txt >> index 57a808b..ffce144 100644 >> --- a/Documentation/devicetree/of_selftest.txt >> +++ b/Documentation/devicetree/of_selftest.txt >> @@ -22,31 +22,31 @@ most of the device drivers in various use cases. >> >> 2. Test-data >> >> -The Device Tree Source file (drivers/of/testcase-data/testcases.dts) contains >> +The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains >> the test data required for executing the unit tests automated in >> -drivers/of/selftests.c. Currently, following Device Tree Source Include files >> -(.dtsi) are included in testcase.dts: >> +drivers/of/unittest.c. Currently, following Device Tree Source Include files >> +(.dtsi) are included in testcases.dts: >> >> -drivers/of/testcase-data/tests-interrupts.dtsi >> -drivers/of/testcase-data/tests-platform.dtsi >> -drivers/of/testcase-data/tests-phandle.dtsi >> -drivers/of/testcase-data/tests-match.dtsi >> +drivers/of/unittest-data/tests-interrupts.dtsi >> +drivers/of/unittest-data/tests-platform.dtsi >> +drivers/of/unittest-data/tests-phandle.dtsi >> +drivers/of/unittest-data/tests-match.dtsi >> >> When the kernel is build with OF_SELFTEST enabled, then the following make rule >> >> $(obj)/%.dtb: $(src)/%.dts FORCE >> $(call if_changed_dep, dtc) >> >> -is used to compile the DT source file (testcase.dts) into a binary blob >> -(testcase.dtb), also referred as flattened DT. >> +is used to compile the DT source file (testcases.dts) into a binary blob >> +(testcases.dtb), also referred as flattened DT. >> >> After that, using the following rule the binary blob above is wrapped as an >> -assembly file (testcase.dtb.S). >> +assembly file (testcases.dtb.S). >> >> $(obj)/%.dtb.S: $(obj)/%.dtb >> $(call cmd, dt_S_dtb) >> >> -The assembly file is compiled into an object file (testcase.dtb.o), and is >> +The assembly file is compiled into an object file (testcases.dtb.o), and is >> linked into the kernel image. >> >> >> -- >> 1.8.3.4 >> > > . >