From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753921AbbCICsy (ORCPT ); Sun, 8 Mar 2015 22:48:54 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:31222 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbbCICst (ORCPT ); Sun, 8 Mar 2015 22:48:49 -0400 Message-ID: <54FD09CD.6010306@huawei.com> Date: Mon, 9 Mar 2015 10:47:41 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Rob Herring CC: Bjorn Helgaas , , "linux-pci@vger.kernel.org" , Guan Xuetao , Russell King , "x86@kernel.org" , Geert Uytterhoeven , Benjamin Herrenschmidt , Arnd Bergmann , Marc Zyngier , Rusty Russell , , Thomas Gleixner , Yinghai Lu , "linux-arm-kernel@lists.infradead.org" , Liviu Dudau , "Tony Luck" , "linux-kernel@vger.kernel.org" , Jiang Liu , , linuxppc-dev , "David S. Miller" Subject: Re: [PATCH v5 16/29] powerpc/pci: Use pci_scan_host_bridge() for simplicity References: <1425634426-437-1-git-send-email-wangyijing@huawei.com> <1425634426-437-17-git-send-email-wangyijing@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A010205.54FD09D4.02A4,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 6442cf54c01d63bb87557a0beb856d40 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/6 22:19, Rob Herring wrote: > On Fri, Mar 6, 2015 at 3:33 AM, Yijing Wang wrote: >> Now we could use pci_scan_host_bridge() to scan >> pci buses, provide powerpc specific pci_host_bridge_ops. >> >> Suggested-by: Arnd Bergmann >> Signed-off-by: Yijing Wang >> CC: Benjamin Herrenschmidt >> CC: linuxppc-dev@lists.ozlabs.org >> Signed-off-by: Bjorn Helgaas >> --- >> arch/powerpc/include/asm/machdep.h | 2 +- >> arch/powerpc/kernel/pci-common.c | 63 ++++++++++++++++++------------ >> arch/powerpc/platforms/pseries/pci.c | 8 ++-- >> arch/powerpc/platforms/pseries/pseries.h | 2 +- >> 4 files changed, 44 insertions(+), 31 deletions(-) >> >> diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm/machdep.h >> index 8e7f2a8..b811d12 100644 >> --- a/arch/powerpc/include/asm/machdep.h >> +++ b/arch/powerpc/include/asm/machdep.h >> @@ -129,7 +129,7 @@ struct machdep_calls { >> void (*pcibios_fixup)(void); >> int (*pci_probe_mode)(struct pci_bus *); >> void (*pci_irq_fixup)(struct pci_dev *dev); >> - int (*pcibios_set_root_bus_speed)(struct pci_host_bridge >> + void (*pcibios_set_root_bus_speed)(struct pci_host_bridge >> *bridge); > > Shouldn't this be part of patch 15? Hi Rob, I didn't merge this to patch 15 for building happy for patch 15. > > Rob > > . > -- Thanks! Yijing