From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751882AbbCIEG5 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Mar 2015 00:06:57 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:60336 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751741AbbCIEGx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Mar 2015 00:06:53 -0400
Message-ID: <54FD1C2A.2070703@huawei.com>
Date: Mon, 9 Mar 2015 12:06:02 +0800
From: "long.wanglong" <long.wanglong@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1
MIME-Version: 1.0
To: Wang Long <long.wanglong@huawei.com>
CC: <gregkh@linuxfoundation.org>, <jslaby@suse.cz>, <bigeasy@linutronix.de>,
        <peter@hurleysoftware.com>, <tony@atomide.com>, <alan@linux.intel.com>,
        <ricardo.ribalda@gmail.com>, <yoshihiro.yunomae.ez@hitachi.com>,
        <andriy.shevchenko@linux.intel.com>, <robh@kernel.org>,
        <Vineet.Gupta1@synopsys.com>, <wsa@the-dreams.de>, <dforsi@gmail.com>,
        <rafael.j.wysocki@intel.com>, <linux-serial@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <peifeiyue@huawei.com>
Subject: Re: [PATCH] serial: 8250: remove the redundant include
References: <1425874376-153286-1-git-send-email-long.wanglong@huawei.com>
In-Reply-To: <1425874376-153286-1-git-send-email-long.wanglong@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.88.174]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015/3/9 12:12, Wang Long wrote:
> The serial_core.h file have been included in header file
> serial_8250.h. so remove the "#include <serial_core.h>" in
> some 8250 serial drivers, because they have included the header file
> serial_8250.h.

missing the 8250_dw.c. i will send another patch.

Thanks
> 
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> ---
>  drivers/tty/serial/8250/8250_core.c  | 1 -
>  drivers/tty/serial/8250/8250_early.c | 1 -
>  drivers/tty/serial/8250/8250_em.c    | 1 -
>  drivers/tty/serial/8250/8250_hp300.c | 1 -
>  drivers/tty/serial/8250/8250_omap.c  | 1 -
>  5 files changed, 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index e3b9570a..7ddd668 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -31,7 +31,6 @@
>  #include <linux/tty.h>
>  #include <linux/ratelimit.h>
>  #include <linux/tty_flip.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial.h>
>  #include <linux/serial_8250.h>
>  #include <linux/nmi.h>
> diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
> index c31a22b..c7ae647 100644
> --- a/drivers/tty/serial/8250/8250_early.c
> +++ b/drivers/tty/serial/8250/8250_early.c
> @@ -29,7 +29,6 @@
>  #include <linux/tty.h>
>  #include <linux/init.h>
>  #include <linux/console.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial_reg.h>
>  #include <linux/serial.h>
>  #include <linux/serial_8250.h>
> diff --git a/drivers/tty/serial/8250/8250_em.c b/drivers/tty/serial/8250/8250_em.c
> index ae5eaed..0b63812 100644
> --- a/drivers/tty/serial/8250/8250_em.c
> +++ b/drivers/tty/serial/8250/8250_em.c
> @@ -21,7 +21,6 @@
>  #include <linux/io.h>
>  #include <linux/module.h>
>  #include <linux/serial_8250.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial_reg.h>
>  #include <linux/platform_device.h>
>  #include <linux/clk.h>
> diff --git a/drivers/tty/serial/8250/8250_hp300.c b/drivers/tty/serial/8250/8250_hp300.c
> index b488208..2891958 100644
> --- a/drivers/tty/serial/8250/8250_hp300.c
> +++ b/drivers/tty/serial/8250/8250_hp300.c
> @@ -10,7 +10,6 @@
>  #include <linux/string.h>
>  #include <linux/kernel.h>
>  #include <linux/serial.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial_8250.h>
>  #include <linux/delay.h>
>  #include <linux/dio.h>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index fe6d2e51..9289999 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -11,7 +11,6 @@
>  #include <linux/io.h>
>  #include <linux/module.h>
>  #include <linux/serial_8250.h>
> -#include <linux/serial_core.h>
>  #include <linux/serial_reg.h>
>  #include <linux/tty_flip.h>
>  #include <linux/platform_device.h>
>