From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbbCIFLY (ORCPT ); Mon, 9 Mar 2015 01:11:24 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:48976 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbbCIFLX (ORCPT ); Mon, 9 Mar 2015 01:11:23 -0400 Message-ID: <54FD2B74.6050300@ti.com> Date: Mon, 9 Mar 2015 10:41:16 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Roger Quadros , Axel Lin CC: Vignesh R , Felipe Balbi , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] phy: omap-control: Remove unneeded ifdef CONFIG_OF guard and of_match_ptr References: <1425550725.21331.1.camel@phoenix> <54F83492.5080103@ti.com> <54F97C08.1060106@ti.com> In-Reply-To: <54F97C08.1060106@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday 06 March 2015 03:36 PM, Roger Quadros wrote: > On 05/03/15 17:29, Axel Lin wrote: >> 2015-03-05 18:48 GMT+08:00 Roger Quadros : >>> Hi Alex, >> It's Axel. > > My apologies Axel. > >> >>> >>> Since we're anyways going to fail probe for !CONFIG_OF, why do you want to >>> add the unnecessary device table to the kernel? >>> >>> what are you benefiting from this change? >> >> If the driver works for both dt case and non-dt case, using the ifdef CONFIG_OF >> guard can save a few memory for non-dt case. >> For dt-only driver it is not required because you cannot use the driver >> if !CONFIG_OF. Which means you should not build this driver at all if !CONFIG_OF >> unless you just want to do compile test. > > I agree. Kishon do we really need to build these drivers if !CONFIG_OF? We can stop building these drivers for !CONFIG_OF since none of the platforms which uses these drivers support non-dt anyway. Cheers Kishon