From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752823AbbCIHZy (ORCPT ); Mon, 9 Mar 2015 03:25:54 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:60692 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbbCIHZx (ORCPT ); Mon, 9 Mar 2015 03:25:53 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: djkurtz@chromium.org X-SENDER-IP: 103.47.144.19 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <3a72bf3fcda3f206e218ec2379a866f8> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54FD4AEA.6000507@rock-chips.com> Date: Mon, 09 Mar 2015 15:25:30 +0800 From: yakir User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Daniel Kurtz CC: David Airlie , Russell King , Philipp Zabel , Fabio Estevam , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , "linux-kernel@vger.kernel.org" , dri-devel , Douglas Anderson , "open list:ARM/Rockchip SoC..." , Rob Clark , Daniel Vetter , =?UTF-8?B?U3TDqXBoYW5lIE1hcmNoZXNpbg==?= , Andy Yan , Shawn Guo , Mark Yao Subject: Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style References: <425876114-22392-1-git-send-email-ykk@rock-chips.com> <1425876147-22456-1-git-send-email-ykk@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年03月09日 15:05, Daniel Kurtz wrote: > On Mon, Mar 9, 2015 at 12:42 PM, Yakir Yang wrote: >> - const struct dw_hdmi_mpll_config *mpll_config = >> - hdmi->plat_data->mpll_cfg; >> - const struct dw_hdmi_curr_ctrl *curr_ctrl = hdmi->plat_data->cur_ctr; >> - const struct dw_hdmi_sym_term *sym_term = hdmi->plat_data->sym_term; >> >> + const struct dw_hdmi_plat_data *plat_data = hdmi->plat_data; >> + const struct dw_hdmi_mpll_config *mpll_config = plat_data->mpll_cfg; >> + const struct dw_hdmi_curr_ctrl *curr_ctrl = plat_data->cur_ctr; >> + const struct dw_hdmi_sym_term *sym_term = plat_data->sym_term; >> >> Signed-off-by: Yakir Yang > I agree with Joe Perches that this commit message is not very clear. > It should summarize what the patches is doing and why, not just be a > copy of the change. > e.g., "Using a local struct pointer to reduce one level of indirection > makes the code slightly more readable." > > , but otherwise this is: > Reviewed-by: Daniel Kurtz Okay, I will correct it now. Thanks for your reivew :) >> --- >> >> Changes in v2: None >> >> drivers/gpu/drm/bridge/dw_hdmi.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >> index 9ffc257..b9d8d8a 100644 >> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >> @@ -900,10 +900,10 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, unsigned char prep, >> { >> unsigned res_idx, i; >> u8 val, msec; >> - const struct dw_hdmi_mpll_config *mpll_config = >> - hdmi->plat_data->mpll_cfg; >> - const struct dw_hdmi_curr_ctrl *curr_ctrl = hdmi->plat_data->cur_ctr; >> - const struct dw_hdmi_sym_term *sym_term = hdmi->plat_data->sym_term; >> + const struct dw_hdmi_plat_data *plat_data = hdmi->plat_data; >> + const struct dw_hdmi_mpll_config *mpll_config = plat_data->mpll_cfg; >> + const struct dw_hdmi_curr_ctrl *curr_ctrl = plat_data->cur_ctr; >> + const struct dw_hdmi_sym_term *sym_term = plat_data->sym_term; >> >> if (prep) >> return -EINVAL; >> -- >> 2.1.2 >> >> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip > >