From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbbCIIlf (ORCPT ); Mon, 9 Mar 2015 04:41:35 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:59611 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753611AbbCIIl1 (ORCPT ); Mon, 9 Mar 2015 04:41:27 -0400 Message-ID: <54FD5C9C.4080609@huawei.com> Date: Mon, 9 Mar 2015 16:41:00 +0800 From: Zhang Zhen User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Greg KH CC: , , , , , Subject: Re: [PATCH] serial: 8250: fix a sparse warning References: <1425886615-78601-1-git-send-email-zhenzhang.zhang@huawei.com> <54FD4EE6.7000408@huawei.com> <20150309082253.GA14349@kroah.com> In-Reply-To: <20150309082253.GA14349@kroah.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.111.68.57] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/9 16:22, Greg KH wrote: > On Mon, Mar 09, 2015 at 03:42:30PM +0800, Zhang Zhen wrote: >> drivers/tty/serial/8250/8250_core.c: In function ‘serial8250_console_write’: >> drivers/tty/serial/8250/8250_core.c:3244: warning: ‘flags’ may be used u >> unitialized in this function >> >> Signed-off-by: Zhang Zhen >> --- >> drivers/tty/serial/8250/8250_core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c >> index deae122..50702e2 100644 >> --- a/drivers/tty/serial/8250/8250_core.c >> +++ b/drivers/tty/serial/8250/8250_core.c >> @@ -3241,7 +3241,7 @@ serial8250_console_write(struct console *co, const char *s, unsigned int count) >> { >> struct uart_8250_port *up = &serial8250_ports[co->index]; >> struct uart_port *port = &up->port; >> - unsigned long flags; >> + unsigned long flags = 0; >> unsigned int ier; >> int locked = 1; >> > > Sparse generated this? Or did a broken / old version of gcc? > Sorry, it's a gcc warning. My gcc version is: gcc (SUSE Linux) 4.3.4 [gcc-4_3-branch revision 152973] > This patch fixes nothing, sorry, so I can't accept it. > > greg k-h > > . >