From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754429AbbCILYs (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Mar 2015 07:24:48 -0400
Received: from mailout3.samsung.com ([203.254.224.33]:30339 "EHLO
	mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754403AbbCILYn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Mar 2015 07:24:43 -0400
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
X-AuditID: cbfee68d-f79296d000004278-ec-54fd82f87a0c
Content-transfer-encoding: 8BIT
Message-id: <54FD82EE.7070408@samsung.com>
Date: Mon, 09 Mar 2015 20:24:30 +0900
From: jonghwa3.lee@samsung.com
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.5.0
To: Oliver Neukum <oneukum@suse.de>, Jenny TC <jenny.tc@intel.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sebastian Reichel <sre@kernel.org>,
        Anton Vorontsov <anton.vorontsov@linaro.org>,
        David Woodhouse <dwmw2@infradead.org>, myungjoo.ham@gmail.com,
        Pallala Ramakrishna <ramakrishna.pallala@intel.com>
Subject: Re: [RFC 2/4] power: core: Add generic interface to get battery
 specification.
References: <1425638007-9411-1-git-send-email-jenny.tc@intel.com>
 <1425638007-9411-3-git-send-email-jenny.tc@intel.com>
 <1425640566.2197.2.camel@suse.de>
In-reply-to: <1425640566.2197.2.camel@suse.de>
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWyRsSkQPdH098Qg4l3pS0utt5msZi4cjKz
	xdqvPewWl3fNYbP43HuE0eL5pk5Wi8UXZ7NaLHxzk8ni9O4SB06PnbPusntsXqHlsXjPSyaP
	Tas62TzuXNvD5rH5dLXH501yAexRXDYpqTmZZalF+nYJXBlvV2xgLbjCXHH2wQr2BsbPTF2M
	nBwSAiYSzT+msELYYhIX7q1nA7GFBJYySlx/qA1Ts/DbUqAaLqD4IkaJs5++gzXzCghK/Jh8
	j6WLkYODWUBe4silbAhTXWLKlFyI8teMEnde7mOGKNeSWHt3CpjNIqAq0bdjFwuIzSYgJ/G2
	6RsjSK+oQITE7cucIGERASeJFT/vgK1lFuhgkujq2MkOkhAWiJS4dO4JM8SCuYwSky5uAbuH
	U0BPYu7BzUwgCQmBt+wSe3/OYYPYJiDxbfIhsEMlBGQlNh1ghnhMUuLgihssExjFZiF5ZxbC
	O7MQ3lnAyLyKUTS1ILmgOCm9yFCvODG3uDQvXS85P3cTIzAmT/971ruD8fYB60OMAhyMSjy8
	O078CRFiTSwrrsw9xGgKdMNEZinR5Hxg5OeVxBsamxlZmJqYGhuZW5opifMqSv0MFhJITyxJ
	zU5NLUgtii8qzUktPsTIxMEp1cDIeP+snO/2PIaLzgGzvzV0mRzcuaSOv2yBJm/InIOLXRZN
	1z6abb528qZbH9Y2f1pu9F8j8c/zdrGlEat/nPOfn+2RcD9y5ezcBXEfriQvPszne3JC49VC
	57m7WKKu2ty3FlPXepN4N67RuvPsKdkdznkFfq19s3e9uKaj5hNf7X6usJbF08RIiaU4I9FQ
	i7moOBEAdw9zsMQCAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRmVeSWpSXmKPExsVy+t9jAd0fTX9DDJ5PF7G42HqbxWLiysnM
	Fmu/9rBbXN41h83ic+8RRovnmzpZLRZfnM1qsfDNTSaL07tLHDg9ds66y+6xeYWWx+I9L5k8
	Nq3qZPO4c20Pm8fm09UenzfJBbBHNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpa
	mCsp5CXmptoqufgE6Lpl5gAdpqRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0k
	rGHMeLtiA2vBFeaKsw9WsDcwfmbqYuTkkBAwkVj4bSkrhC0mceHeerYuRi4OIYFFjBJnP30H
	K+IVEJT4MfkeSxcjBwezgLzEkUvZEKa6xJQpuRDlrxkl7rzcxwxRriWx9u4UMJtFQFWib8cu
	FhCbTUBO4m3TN0aQXlGBCInblzlBwiICThIrft5hBZnDLNDBJNHVsZMdJCEsEClx6dwTZogF
	cxklJl3cAnYPp4CexNyDm5kmMArMQnLeLITzZiGct4CReRWjaGpBckFxUnqukV5xYm5xaV66
	XnJ+7iZGcMw/k97BuKrB4hCjAAejEg/vjhN/QoRYE8uKK3MPMUpwMCuJ8Lpl/A0R4k1JrKxK
	LcqPLyrNSS0+xGgK9NxEZinR5HxgOsoriTc0NjEzsjQyN7QwMjZXEudVsm8LERJITyxJzU5N
	LUgtgulj4uCUamCcr8xlr+JdvKnx1UL2lbU7Hv3WfCsgcliw/cmGwEPRygczNl88kdH/8NCG
	okRWc6M/vMVaf3e6/yyq2Ga0fs+OoPp0xw2m9ZMvGCyMfnCQZWZ90teLuznr4x06i5ffEIjZ
	2ii+bf8vF/Oltkn+Cbf3PoxX0YyofmcRviCbJXCn1MsFnAvbE1WVWIozEg21mIuKEwGuCOR2
	DwMAAA==
DLP-Filter: Pass
X-MTR: 20000000000000000@CPGS
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,
2015년 03월 06일 20:16에 Oliver Neukum 이(가) 쓴 글:
>> +
>> +	/* Check if same data is existed */
>> +	list_for_each_entry(battery, &psy_battery_info_list, entry)
>> +		if (!strcmp(battery->info->name, info->name))
>> +			return -EEXIST;
>> +
>> +	battery = kzalloc(sizeof(*battery), GFP_KERNEL);
> 
> That is a race condition. If you check for duplication, you'll
> need a lock.
> 

Yes, you`re right. I`ll apply it.

Thanks,
Jonghwa