From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbbCILqi (ORCPT ); Mon, 9 Mar 2015 07:46:38 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:36595 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754419AbbCILqd (ORCPT ); Mon, 9 Mar 2015 07:46:33 -0400 X-AuditID: cbfee68d-f79296d000004278-23-54fd881422a9 Message-id: <54FD880E.30903@samsung.com> Date: Mon, 09 Mar 2015 20:46:22 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Lee Jones , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov Subject: Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver References: <1425291038-18269-1-git-send-email-jaewon02.kim@samsung.com> <1425291038-18269-3-git-send-email-jaewon02.kim@samsung.com> <20150307201340.GF5233@earth> <54FCEABE.9000007@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsWyRsSkSFek42+IwbGNZhbXvzxntZh/5Byr xeFFLxgt+t8sZLU492olo8Wk+xNYLHY0HGG1eP3C0OL+16OMFjc/fWO1uLxrDpvF594jjBZL r19kspgwfS2LReveI+wWxz8dZLE4vbvEQdBjzbw1jB6X+3qZPHbOusvusXL5FzaPTas62Tzu XNvD5tG3ZRWjx+dNcgEcUVw2Kak5mWWpRfp2CVwZ1w69Zy94JVCx8GMnawPjdd4uRg4OCQET iRkfLLsYOYFMMYkL99azdTFycQgJLGWU+DN3OStEwkTizrwXjBCJRYwSHVNXQ1W9ZpRYsuIN G8gkXgENiQnzpEAaWARUJQ61bmYDsdkENCXeT7nCAlIiKhAhcfsyJ0iYV0BQ4sfkeywgtoiA ocTB3duZQEYyCxxjkVi2cAlYQlggUmLitutQu3qZJO7N2wY2lFMgWKLr/zJmkKHMAuoSU6bk goSZBeQlNq95ywxSLyGwhUPiw4EzTBAHCUh8m3yIBeJjWYlNB5ghHpOUOLjiBssERrFZSG6a hTB1FpKpCxiZVzGKphYkFxQnpRcZ6hUn5haX5qXrJefnbmIERvzpf896dzDePmB9iFGAg1GJ h3fHiT8hQqyJZcWVuYcYTYGOmMgsJZqcD0wreSXxhsZmRhamJqbGRuaWZkrivIpSP4OFBNIT S1KzU1MLUovii0pzUosPMTJxcEo1ME67JfFClal840Kb6kcS171WvE0OM1tRUKRWqrP5xZ5N H9Oe3TY5naIi/DBlqvnFzWkW+Q0/bziIqfu+n9+ruUr+W3jh9nenWDdrt507Ict2fqtyyOSF Cd9vy1pNcJCb1STeeO43mwpzvMf9T6f+xduo6xzYyfBKTOCsnqBL8CUJnTuRf+4GmCqxFGck GmoxFxUnAgCIKVVX8wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsVy+t9jAV2Rjr8hBlcf61hc//Kc1WL+kXOs FocXvWC06H+zkNXi3KuVjBaT7k9gsdjRcITV4vULQ4v7X48yWtz89I3V4vKuOWwWn3uPMFos vX6RyWLC9LUsFq17j7BbHP90kMXi9O4SB0GPNfPWMHpc7utl8tg56y67x8rlX9g8Nq3qZPO4 c20Pm0ffllWMHp83yQVwRDUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl 5qbaKrn4BOi6ZeYAvaGkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzLh2 6D17wSuBioUfO1kbGK/zdjFyckgImEjcmfeCEcIWk7hwbz1bFyMXh5DAIkaJjqmroZzXjBJL VrwBcjg4eAU0JCbMkwJpYBFQlTjUupkNxGYT0JR4P+UKC0iJqECExO3LnCBhXgFBiR+T77GA 2CIChhIHd29nAhnJLHCMRWLZwiVgCWGBSImJ265D7eplkrg3bxvYUE6BYImu/8uYQYYyC6hL TJmSCxJmFpCX2LzmLfMERoFZSHbMQqiahaRqASPzKkbR1ILkguKk9FxDveLE3OLSvHS95Pzc TYzghPJMagfjygaLQ4wCHIxKPLw7TvwJEWJNLCuuzD3EKMHBrCTC65bxN0SINyWxsiq1KD++ qDQntfgQoykwACYyS4km5wOTXV5JvKGxiZmRpZG5oYWRsbmSOK+SfVuIkEB6YklqdmpqQWoR TB8TB6dUA6P8OfaXFtsnxrYec/w/pf5RiZbAS2l/65fOIS2VKWk7GP0ardVW+VoKdLwTEeiQ +37CSOHKG/EjP2K/bfjKKl6s0PLwo4bTg8lP3n7cW9Azl72zyO/WL1tFhYaP/3qmXy66/OLc vZ+Vv2cYfLc0s3qoxjol36bFR3fGBenjO0TZOBYE80lJuSuxFGckGmoxFxUnAgAo7ui6PgMA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2015 08:02 PM, Krzysztof Kozlowski wrote: > 2015-03-09 1:35 GMT+01:00 Beomho Seo : >> On 03/08/2015 05:13 AM, Sebastian Reichel wrote: >>> On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote: >>>> From: Beomho Seo >>>> >>>> This patch adds device driver of max77843 charger. This driver provide >>>> initialize each charging mode(e.g. fast charge, top-off mode and constant >>>> charging mode so on.). Additionally, control charging paramters to use >>>> i2c interface. >>>> >>>> Cc: Sebastian Reichel >>>> Signed-off-by: Beomho Seo >>> >>> Reviewed-By: Sebastian Reichel >>> >>> I can't take it as is, since it depends on the private header file >>> of PATCHv1. >>> >>> -- Sebastian >>> >> >> This patch reviewed by Sebastian. >> Could you Please merge that your git tree ? > > Hi, > > ... and again we are adding a new driver for very similar chipset to > already supported. I looked at spec and the charger's registers are > almost the same as for max77693. Their layout and addresses are the > same. I see some minor differences, probably the most important would > be different values current (fast-charge, top-off). But still 90% of > registers are the same... Do we really have to add new driver? > > Best regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Hi, Thank you for your comment. As you say, both chip set are similar. But new driver need for support max77843. It is support different below - Provide Battery presence information. - Can OTG FET control. - Bigger Fast charge current, Top Off current Threshold selection. - Various and bigger OTG current limitation. - Bigger primary charger termination voltage setting. - Different maximum input current limit selection(Different step). I respect your opinion but I think add new driver better. Best regards, Beomho Seo