From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbbCILys (ORCPT ); Mon, 9 Mar 2015 07:54:48 -0400 Received: from smtp-out-094.synserver.de ([212.40.185.94]:1067 "EHLO smtp-out-094.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbbCILyq (ORCPT ); Mon, 9 Mar 2015 07:54:46 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 8723 Message-ID: <54FD8A0A.4080909@metafoo.de> Date: Mon, 09 Mar 2015 12:54:50 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , broonie@kernel.org, lgirdwood@gmail.com CC: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Subject: Re: [PATCH_V2] ASoC: jz4740: Add jz4780 support References: <1425900224-52026-1-git-send-email-Zubair.Kakakhel@imgtec.com> In-Reply-To: <1425900224-52026-1-git-send-email-Zubair.Kakakhel@imgtec.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2015 12:23 PM, Zubair Lutfullah Kakakhel wrote: [...] > @@ -460,6 +499,9 @@ static int jz4740_i2s_dev_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, i2s); > > + if (i2s->version >= JZ_I2S_JZ4780) > + jz4740_i2s_dai.symmetric_rates = 0; We shouldn't modify driver global structs from a device instance. Just add a second copy of jz4740_i2s_dai for the jz4780 without the bit set. - Lars