From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932262AbbCIOAJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Mar 2015 10:00:09 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:25215 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753364AbbCIOAE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Mar 2015 10:00:04 -0400
Message-ID: <54FDA752.90302@huawei.com>
Date: Mon, 9 Mar 2015 21:59:46 +0800
From: "Chentao (Boby)" <boby.chen@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Joe Perches <joe@perches.com>
CC: <jgross@suse.com>, <konrad.wilk@oracle.com>, <boris.ostrovsky@oracle.com>,
        <david.vrabel@citrix.com>, <xen-devel@lists.xenproject.org>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <wu.wubin@huawei.com>, <rudy.zhangmin@huawei.com>
Subject: Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK
References: <1425493951-41801-1-git-send-email-boby.chen@huawei.com>	 <1425486739.2712.12.camel@perches.com> <54F97456.2070102@huawei.com> <1425646243.12017.28.camel@perches.com>
In-Reply-To: <1425646243.12017.28.camel@perches.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.25.98]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020206.54FDA761.040E,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 652886a39585debda436ec8b10ca84cb
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2015/3/6 20:50, Joe Perches wrote:
> On Fri, 2015-03-06 at 17:33 +0800, Chentao (Boby) wrote:
>> #ifdef pr_fmt
>> #undef pr_fmt
>> #endif
>> #define pr_fmt(fmt) "xen-pvscsi: " fmt
>
> No, just use add
> #define pr_fmt(fmt) "xen-pvscsi: " fmt
> before the first #include.
> The #ifdef/#undef/#endif isn't necessary.
>
>> Then replace all DPRINTK with pr_debug.
>
> Yes on this one.
>

Thanks very much, Joe.

>
>
>
> .
>