From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>, Paul Bolle <pebolle@tiscali.nl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kumar Gala <galak@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms
Date: Mon, 09 Mar 2015 18:53:33 +0200 [thread overview]
Message-ID: <54FDD00D.6000808@mm-sol.com> (raw)
In-Reply-To: <1424696228.2340.7.camel@mm-sol.com>
On 02/23/2015 02:57 PM, Ivan T. Ivanov wrote:
>
> On Wed, 2015-02-04 at 19:46 +0100, Paul Bolle wrote:
>> On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote:
>>> On 02/04/2015 05:14 PM, Paul Bolle wrote:
>>>> On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
>>>>> On 02/03/2015 10:42 PM, Paul Bolle wrote:
>>>>>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
>>>>>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
>>>>>>> index bf1295e..115348c 100644
>>>>>>> --- a/drivers/spmi/Kconfig
>>>>>>> +++ b/drivers/spmi/Kconfig
>>>>>>> @@ -12,7 +12,7 @@ if SPMI
>>>>>>>
>>>>>>> config SPMI_MSM_PMIC_ARB
>>>>>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
>>>>>>> - depends on ARM
>>>>>>> + depends on ARM || ARM64
>>>>>>> depends on IRQ_DOMAIN
>>>>>>> depends on ARCH_QCOM || COMPILE_TEST
>>>>>>> default ARCH_QCOM
>>>>>>
>>>>>> But only if COMPILE_TEST is set too, isn't it? Is that intended?
>>>>>
>>>>> No, the driver will be used on arm64 qcom platforms, also.
>>>>
>>>> But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?
>>>
>>> Currently yes, but we want to be prepared to support PMIC's which will
>>> be used on arm64 platforms, although they are not upstream yet.
>>
>> Please make the commit summary reflect that, as in:
>> "spmi: pmic_arb: enable test build on arm64"
>>
>> Commit explanation likewise.
>
> What if we just drop ARM dependency?
I'm fine with this, Paul?
--
regards,
Stan
next prev parent reply other threads:[~2015-03-09 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 13:50 [PATCH] spmi: pmic_arb: enable build on arm64 platforms Stanimir Varbanov
2015-02-03 20:42 ` Paul Bolle
2015-02-04 15:05 ` Stanimir Varbanov
2015-02-04 15:14 ` Paul Bolle
2015-02-04 15:27 ` Stanimir Varbanov
2015-02-04 18:46 ` Paul Bolle
2015-02-23 12:57 ` Ivan T. Ivanov
2015-03-09 16:53 ` Stanimir Varbanov [this message]
2015-03-09 18:57 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FDD00D.6000808@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).