From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753664AbbCIQxo (ORCPT ); Mon, 9 Mar 2015 12:53:44 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:42374 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751012AbbCIQxl (ORCPT ); Mon, 9 Mar 2015 12:53:41 -0400 Message-ID: <54FDD00D.6000808@mm-sol.com> Date: Mon, 09 Mar 2015 18:53:33 +0200 From: Stanimir Varbanov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: "Ivan T. Ivanov" , Paul Bolle CC: Greg Kroah-Hartman , Kumar Gala , Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms References: <1422971459-20431-1-git-send-email-svarbanov@mm-sol.com> <1422996157.23894.35.camel@x220> <54D23527.2080509@mm-sol.com> <1423062897.23022.19.camel@x220> <54D23A47.8040908@mm-sol.com> <1423075571.27378.2.camel@x220> <1424696228.2340.7.camel@mm-sol.com> In-Reply-To: <1424696228.2340.7.camel@mm-sol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/23/2015 02:57 PM, Ivan T. Ivanov wrote: > > On Wed, 2015-02-04 at 19:46 +0100, Paul Bolle wrote: >> On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote: >>> On 02/04/2015 05:14 PM, Paul Bolle wrote: >>>> On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote: >>>>> On 02/03/2015 10:42 PM, Paul Bolle wrote: >>>>>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote: >>>>>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig >>>>>>> index bf1295e..115348c 100644 >>>>>>> --- a/drivers/spmi/Kconfig >>>>>>> +++ b/drivers/spmi/Kconfig >>>>>>> @@ -12,7 +12,7 @@ if SPMI >>>>>>> >>>>>>> config SPMI_MSM_PMIC_ARB >>>>>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" >>>>>>> - depends on ARM >>>>>>> + depends on ARM || ARM64 >>>>>>> depends on IRQ_DOMAIN >>>>>>> depends on ARCH_QCOM || COMPILE_TEST >>>>>>> default ARCH_QCOM >>>>>> >>>>>> But only if COMPILE_TEST is set too, isn't it? Is that intended? >>>>> >>>>> No, the driver will be used on arm64 qcom platforms, also. >>>> >>>> But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it? >>> >>> Currently yes, but we want to be prepared to support PMIC's which will >>> be used on arm64 platforms, although they are not upstream yet. >> >> Please make the commit summary reflect that, as in: >> "spmi: pmic_arb: enable test build on arm64" >> >> Commit explanation likewise. > > What if we just drop ARM dependency? I'm fine with this, Paul? -- regards, Stan