From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbbCIW3Y (ORCPT ); Mon, 9 Mar 2015 18:29:24 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54581 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbbCIW3X (ORCPT ); Mon, 9 Mar 2015 18:29:23 -0400 Message-ID: <54FE1EC0.6000201@osg.samsung.com> Date: Mon, 09 Mar 2015 16:29:20 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Dave Jones , Michael Ellerman , linux-kernel@vger.kernel.org, mmarek@suse.cz, linux-api@vger.kernel.org Subject: Re: [PATCH 2/9] selftests: Add install target References: <1425358302-16680-1-git-send-email-mpe@ellerman.id.au> <1425358302-16680-2-git-send-email-mpe@ellerman.id.au> <20150305185326.GA30620@codemonkey.org.uk> <54FDAC4A.9080703@osg.samsung.com> In-Reply-To: <54FDAC4A.9080703@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2015 08:20 AM, Shuah Khan wrote: > On 03/05/2015 11:53 AM, Dave Jones wrote: >> On Tue, Mar 03, 2015 at 03:51:35PM +1100, Michael Ellerman wrote: >> > This adds make install support to selftests. The basic usage is: >> > >> > $ cd tools/testing/selftests >> > $ make install >> > >> > That installs into tools/testing/selftests/install, which can then be >> > copied where ever necessary. >> > >> > The install destination is also configurable using eg: >> > >> > $ INSTALL_PATH=/mnt/selftests make install >> >> ... >> >> > + @# Ask all targets to emit their test scripts >> > + echo "#!/bin/bash\n\n" > $(ALL_SCRIPT) >> >> $ ./all.sh >> -bash: ./all.sh: /bin/bash\n\n: bad interpreter: No such file or directory >> >> Removing the \n\n fixes it. >> >> > + echo "cd \$$ROOT\n" >> $(ALL_SCRIPT); \ >> >> ditto >> >> Dave > > Michael, > > Could you please fix these problems and send the patch. > Michael, Did you happen to run run_kselftest.sh from the install directory to make sure all the dependent executables are installed? You are missing a few required dependencies. efivars test for example. Please run kselftest_install.sh I sent out for review and compare the following: - contents of install directory created with your patch vs. my kselftest_install.sh tool - Compare your run_kselftest.sh run with the one that gets generated with my kselftest_install.sh tool General rule is all tests that get run when run_tests target is run should run from the install directory using the run_kselftest.sh generated during install. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978