From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752675AbbCJDrA (ORCPT ); Mon, 9 Mar 2015 23:47:00 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:21666 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbbCJDq7 (ORCPT ); Mon, 9 Mar 2015 23:46:59 -0400 Message-ID: <54FE6902.1010603@huawei.com> Date: Tue, 10 Mar 2015 11:46:10 +0800 From: He Kuang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: , , CC: , Subject: Re: [PATCH 1/2] tracing: remove ftrace:function TRACE_EVENT_FL_USE_CALL_FILTER flag References: <1425367294-27852-1-git-send-email-hekuang@huawei.com> In-Reply-To: <1425367294-27852-1-git-send-email-hekuang@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.110.54.65] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping.. On 2015/3/3 15:21, He Kuang wrote: > TRACE_EVENT_FL_USE_CALL_FILTER flag in ftrace:functon event can be > removed. This flag was first introduced in commit > f306cc82a93d ("tracing: Update event filters for multibuffer"). > > Now, the only place uses this flag is ftrace:function, but the filter of > ftrace:function has a different code path with events/syscalls and > events/tracepoints. It uses ftrace_filter_write() and perf's > ftrace_profile_set_filter() to set the filter, the functionality of file > 'tracing/events/ftrace/function/filter' is bypassed in function > init_pred(), in which case, neither call->filter nor file->filter is > used. > > So we can safely remove TRACE_EVENT_FL_USE_CALL_FILTER flag from > ftrace:function events. > > Signed-off-by: He Kuang > --- > kernel/trace/trace_export.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c > index 12e2b99..174a6a7 100644 > --- a/kernel/trace/trace_export.c > +++ b/kernel/trace/trace_export.c > @@ -177,7 +177,7 @@ struct ftrace_event_call __used event_##call = { \ > }, \ > .event.type = etype, \ > .print_fmt = print, \ > - .flags = TRACE_EVENT_FL_IGNORE_ENABLE | TRACE_EVENT_FL_USE_CALL_FILTER, \ > + .flags = TRACE_EVENT_FL_IGNORE_ENABLE, \ > }; \ > struct ftrace_event_call __used \ > __attribute__((section("_ftrace_events"))) *__event_##call = &event_##call;