From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753270AbbCJIel (ORCPT ); Tue, 10 Mar 2015 04:34:41 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:59710 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbbCJIef (ORCPT ); Tue, 10 Mar 2015 04:34:35 -0400 Message-ID: <54FEAC8F.1040206@atmel.com> Date: Tue, 10 Mar 2015 09:34:23 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Linus Walleij , Jean-Christophe Plagniol-Villard CC: Boris Brezillon , Alexandre Belloni , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Jean-Jacques Hiblot Subject: Re: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods References: <1423419822-6258-1-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 09/03/2015 17:14, Linus Walleij a écrit : > On Sun, Feb 8, 2015 at 7:23 PM, Boris Brezillon > wrote: > >> The gpiochip_lock_as_irq call can fail and return an error, while the >> irq_startup is not expected to fail (returns an unsigned int which is not >> checked by irq core code). >> >> irq_request/release_resources functions have been created to address this >> problem. >> >> Move gpiochip_lock/unlock_as_irq calls into >> irq_request/release_resources functions to prevent using a gpio as an irq >> if the gpiochip_lock_as_irq call failed. >> >> Signed-off-by: Boris Brezillon > > Patch applied with all the ACKs. Hi Linus, As suggested earlier, do you think it can be scheduled for the 4.0-rc phase as a "fix"? Bye, > Happy new year J-C! > > Yours, > Linus Walleij > > -- Nicolas Ferre