From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbbCJNoW (ORCPT ); Tue, 10 Mar 2015 09:44:22 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:12253 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230AbbCJNoR (ORCPT ); Tue, 10 Mar 2015 09:44:17 -0400 X-AuditID: cbfee68d-f79296d000004278-15-54fef52ea8ff Message-id: <54FEF52E.7060409@samsung.com> Date: Tue, 10 Mar 2015 22:44:14 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Lee Jones , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov Subject: Re: [PATCH v7 3/5] power: max77843_battery: Add Max77843 fuel gauge device driver References: <1425291038-18269-1-git-send-email-jaewon02.kim@samsung.com> <1425291038-18269-4-git-send-email-jaewon02.kim@samsung.com> <20150307201426.GG5233@earth> <54FCEB17.70809@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWyRsSkSFf/678Qg/0HWC2uf3nOajH/yDlW i8OLXjBa9L9ZyGpx7tVKRotJ9yewWOxoOMJq8fqFocX9r0cZLW5++sZqcXnXHDaLz71HGC2W Xr/IZDFh+loWi9a9R9gtjn86yGJxeneJg6DHmnlrGD0u9/UyeeycdZfdY+XyL2wem1Z1snnc ubaHzaNvyypGj8+b5AI4orhsUlJzMstSi/TtErgymud+ZC04yVux8MchtgbG31xdjJwcEgIm Eu0PZzBD2GISF+6tZ+ti5OIQEljKKLF4+RYWmKJFvZ8YQWwhgemMEn3ntSGKXjNKbFl+hwkk wSugJdHd/BtsEouAqsSmSbfAbDYBTYn3U64ADeLgEBWIkLh9mROiXFDix+R7YPNFBAwlDu7e zgQyk1ngGIvEsoVLwBLCAjESG7pOskAs62aS6P7aCraMUyBYounzSTaQocwC6hJTpuSChJkF 5CU2r3nLDFIvIbCFQ+L8/J/sEAcJSHybfAjsCAkBWYlNB6A+lpQ4uOIGywRGsVlIbpqFMHUW kqkLGJlXMYqmFiQXFCelFxnqFSfmFpfmpesl5+duYgTG/Ol/z3p3MN4+YH2IUYCDUYmHl8Hk X4gQa2JZcWXuIUZToCMmMkuJJucDE0teSbyhsZmRhamJqbGRuaWZkjivotTPYCGB9MSS1OzU 1ILUovii0pzU4kOMTBycUg2MjoLXT255MnNL3qHXvgetTVVWCEh8XCl5h/NKEt9r7UWxPW/+ bbwWY6mhGu3ScvjkfoU1k+vSDS0f/Lp21O9wftWbL9dMWC7u2p8RGrT7Tdsuk53f7uYVKf8U tue3dmgqEL9/1qR16f0eF4OlHTcdV58rquvMrvjG/UbE7YkUg/TE983nohcFKLEUZyQaajEX FScCAJTjLAz0AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsVy+t9jQV29r/9CDCbcsbC4/uU5q8X8I+dY LQ4vesFo0f9mIavFuVcrGS0m3Z/AYrGj4QirxesXhhb3vx5ltLj56RurxeVdc9gsPvceYbRY ev0ik8WE6WtZLFr3HmG3OP7pIIvF6d0lDoIea+atYfS43NfL5LFz1l12j5XLv7B5bFrVyeZx 59oeNo++LasYPT5vkgvgiGpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshL zE21VXLxCdB1y8wBekNJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmNE8 9yNrwUneioU/DrE1MP7m6mLk5JAQMJFY1PuJEcIWk7hwbz0biC0kMJ1Rou+8dhcjF5D9mlFi y/I7TCAJXgEtie7m38wgNouAqsSmSbfAbDYBTYn3U66wdDFycIgKREjcvswJUS4o8WPyPRYQ W0TAUOLg7u1MIDOZBY6xSCxbuAQsISwQI7Gh6yQLxLJuJonur61gyzgFgiWaPp9kAxnKLKAu MWVKLkiYWUBeYvOat8wTGAVmIdkxC6FqFpKqBYzMqxhFUwuSC4qT0nON9IoTc4tL89L1kvNz NzGCE8oz6R2MqxosDjEKcDAq8fAymPwLEWJNLCuuzD3EKMHBrCTCW3oUKMSbklhZlVqUH19U mpNafIjRFBgAE5mlRJPzgckuryTe0NjEzMjSyNzQwsjYXEmcV8m+LURIID2xJDU7NbUgtQim j4mDU6qB0fbdv3ndVeHmYdm/lx3LFqzhPrDu1tcb51qjYmcxxmhHuD6uePJV7lXCp1eM8+eW pk958PHHvYM+eUUlkQ5XpLqnvkoyNG+6Inb06M72/1uZ+x0/BznkOxnsc/gisaPkxK8K/zqn nWdn7HtxafGCiXd4v4QLeVReZ9v+1Pb2z08PuadbOCm82qfEUpyRaKjFXFScCACR36cgPgMA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2015 07:01 PM, Krzysztof Kozlowski wrote: > 2015-03-09 1:36 GMT+01:00 Beomho Seo : >> On 03/08/2015 05:14 AM, Sebastian Reichel wrote: >>> Hi, >>> >>> On Mon, Mar 02, 2015 at 07:10:36PM +0900, Jaewon Kim wrote: >>>> From: Beomho Seo >>>> >>>> This patch adds device driver of max77843 fuel gauge. >>>> The driver support for battery fuel gauge in Maxim Max77843. >>>> It is fuel-gauge systems for lithuum-ion batteries in handled and >>>> portable devices. >>>> >>>> Cc: Sebastian Reichel >>>> Signed-off-by: Beomho Seo >>> >>> Reviewed-By: Sebastian Reichel >>> >>> I can't take it as is, since it depends on the private header file >>> of PATCH 1. >>> >>> -- Sebastian >>> >> >> This patch reviewed by Sebastian. >> Could you Please merge that your git tree ? > > Hi, > > Sorry for late response, but I finally got some time to look at this. > This driver looks very similar to max17042_battery.c fuel gauge > driver. Obtaining some properties looks exactly the same. The > difference seems to be in new properties. The I2C address is the same. > > I highly recommend to extend the max17042 driver instead. It already > supports also max17047, max17050 and max77693. > > Best regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > OK. I will follow your opinion about fuel gauge. I will extend the max17042 driver. After test on my board, I will send a new patch set. Best regards, Beomho Seo