From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbbCJNoj (ORCPT ); Tue, 10 Mar 2015 09:44:39 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:12306 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbbCJNof (ORCPT ); Tue, 10 Mar 2015 09:44:35 -0400 X-AuditID: cbfee68e-f79b46d000002b74-d4-54fef5415b46 Message-id: <54FEF541.6000305@samsung.com> Date: Tue, 10 Mar 2015 22:44:33 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Lee Jones , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov Subject: Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver References: <1425291038-18269-1-git-send-email-jaewon02.kim@samsung.com> <1425291038-18269-3-git-send-email-jaewon02.kim@samsung.com> <20150307201340.GF5233@earth> <54FCEABE.9000007@samsung.com> <54FD880E.30903@samsung.com> <1425903199.13415.9.camel@AMDC1943> In-reply-to: <1425903199.13415.9.camel@AMDC1943> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsWyRsSkUNfx678Qg11L9Cyuf3nOajH/yDlW i8OLXjBa9L9ZyGpx7tVKRotJ9yewWOxoOMJq8fqFocX9r0cZLW5++sZqcXnXHDaLz71HGC2W Xr/IZDFh+loWi9a9R9gtjn86yGJxeneJg6DHmnlrGD0u9/UyeeycdZfdY+XyL2wem1Z1snnc ubaHzaNvyypGj8+b5AI4orhsUlJzMstSi/TtErgyvn/bwFqwUK7i3+OYBsarEl2MHBwSAiYS O5cZdzFyApliEhfurWfrYuTiEBJYyihxceZ5FoiEicSPyZMZIRLTGSVmvX3LDuG8ZpRoezSd DaSKV0BL4tzKFYwgU1kEVCVWLTAFCbMJaEq8n3KFBSQsKhAhcfsyJ0S1INDMe2DzRQQMJQ7u 3s4EMpJZ4BiLxLKFS8ASwgKREhO3XYe66AKTxOw3/awgCU4BA4lpBy8xgwxlFlCXmDIlFyTM LCAvsXnNW2aQegmBlRwSK443gNWzCAhIfJt8iAXiY1mJTQeYIR6TlDi44gbLBEaxWUhumoUw dRaSqQsYmVcxiqYWJBcUJ6UXGekVJ+YWl+al6yXn525iBMb76X/P+nYw3jxgfYhRgINRiYeX weRfiBBrYllxZe4hRlOgIyYyS4km5wOTSl5JvKGxmZGFqYmpsZG5pZmSOG+C1M9gIYH0xJLU 7NTUgtSi+KLSnNTiQ4xMHJxSDYwzxA4kPn648VvsveXiVUx3j6/LkO5YfjtlSQpzrXSA977G fs4JG/9un8zT98Nom07nLnXzjuWzCytuGaad+LlJ5K7oF+n5pX/jfebmVbW9eZmmdvb9I3sD Du8n1UJ/NCOvbV40d+XJZ7XGr1MulMb/eZMnfvFATm3mHrWF8Zyq9RcDv17rleFSYinOSDTU Yi4qTgQAFCZBxPICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFKsWRmVeSWpSXmKPExsVy+t9jQV3Hr/9CDPb+ULa4/uU5q8X8I+dY LQ4vesFo0f9mIavFuVcrGS0m3Z/AYrGj4QirxesXhhb3vx5ltLj56RurxeVdc9gsPvceYbRY ev0ik8WE6WtZLFr3HmG3OP7pIIvF6d0lDoIea+atYfS43NfL5LFz1l12j5XLv7B5bFrVyeZx 59oeNo++LasYPT5vkgvgiGpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshL zE21VXLxCdB1y8wBekNJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmPH9 2wbWgoVyFf8exzQwXpXoYuTkkBAwkfgxeTIjhC0mceHeerYuRi4OIYHpjBKz3r5lh3BeM0q0 PZrOBlLFK6AlcW7lCqAODg4WAVWJVQtMQcJsApoS76dcYQEJiwpESNy+zAlRLQg0/x4LiC0i YChxcPd2JpCRzALHWCSWLVwClhAWiJSYuO061OILTBKz3/SzgiQ4BQwkph28xAwylFlAXWLK lFyQMLOAvMTmNW+ZJzAKzEKyYxZC1SwkVQsYmVcxiqYWJBcUJ6XnGuoVJ+YWl+al6yXn525i BKeTZ1I7GFc2WBxiFOBgVOLhZTD5FyLEmlhWXJl7iFGCg1lJhLf0KFCINyWxsiq1KD++qDQn tfgQoynQ/xOZpUST84GpLq8k3tDYxMzI0sjc0MLI2FxJnFfJvi1ESCA9sSQ1OzW1ILUIpo+J g1OqgdHBcrmqpXYgj7l2sG0B/9TscCNekxb29zqC+9z5GA0ydpqyBtjEN+ZElh8IeDf9upv+ 2zKR5O3NxWtXZlwuNY49/tXe/aWuG2t62O+il5Mq7KdonjYJ9DkR1VbaN6nwU3S1i9XCpSqV 4r8N+ObpSYoxXZ7D23Uxq47pf5Xr57XLfJl71/UpsRRnJBpqMRcVJwIADR4Lez0DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2015 09:13 PM, Krzysztof Kozlowski wrote: > On pon, 2015-03-09 at 20:46 +0900, Beomho Seo wrote: >> On 03/09/2015 08:02 PM, Krzysztof Kozlowski wrote: >>> 2015-03-09 1:35 GMT+01:00 Beomho Seo : >>>> On 03/08/2015 05:13 AM, Sebastian Reichel wrote: >>>>> On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote: >>>>>> From: Beomho Seo >>>>>> >>>>>> This patch adds device driver of max77843 charger. This driver provide >>>>>> initialize each charging mode(e.g. fast charge, top-off mode and constant >>>>>> charging mode so on.). Additionally, control charging paramters to use >>>>>> i2c interface. >>>>>> >>>>>> Cc: Sebastian Reichel >>>>>> Signed-off-by: Beomho Seo >>>>> >>>>> Reviewed-By: Sebastian Reichel >>>>> >>>>> I can't take it as is, since it depends on the private header file >>>>> of PATCHv1. >>>>> >>>>> -- Sebastian >>>>> >>>> >>>> This patch reviewed by Sebastian. >>>> Could you Please merge that your git tree ? >>> >>> Hi, >>> >>> ... and again we are adding a new driver for very similar chipset to >>> already supported. I looked at spec and the charger's registers are >>> almost the same as for max77693. Their layout and addresses are the >>> same. I see some minor differences, probably the most important would >>> be different values current (fast-charge, top-off). But still 90% of >>> registers are the same... Do we really have to add new driver? >>> >>> Best regards, >>> Krzysztof >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-input" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> >> Hi, >> >> Thank you for your comment. As you say, both chip set are similar. >> But new driver need for support max77843. It is support different below >> - Provide Battery presence information. > > Another set of power supply properties could be added for that chip. > This way the get_property() function would be the same but actually the > POWER_SUPPLY_PROP_PRESENT won't be called for max77693. > >> - Can OTG FET control. > > Where the OTG FET feature is it enabled in your driver? I couldn't find > it. > Sorry. This driver don't control OTG FET feature. >> - Bigger Fast charge current, Top Off current Threshold selection. >> - Various and bigger OTG current limitation. >> - Bigger primary charger termination voltage setting. >> - Different maximum input current limit selection(Different step). > > Yes, I mentioned some of these differences (the Fast/top-off > differences). These are differences in values so it does not require new > driver. There is need to develop new driver just to support different > current (3.0 A instead of 2.1 A) or voltage threshold. > They are different charging current, OTG current limitation, top off current, charging limitation value. In case OTG current limitation different not limitation value but using register bit(max77843 use[7:6] max77693 use[7] bit only). Even if this driver not support all feature, some register different with max77693(support value, use register bit). If this driver will combined with max77693 may even be beneficial for new Maxim driver. But the present, this driver is related with max77843 core driver and max77843-regulator. So I hope this driver merge first. And then will extend two driver(max77843 charger and max77693 charger). > So the only new feature - battery presence - can be easily added to > existing driver. The driver can be extended for different > current/voltage values. Such extension may even be beneficial for new > Maxim MUIC/PMIC chipsets. > > > Best regards, > Krzysztof > Best regards, Beomho Seo