Re: [PATCH 1/2] pinctrl: bindings: pinctrl: Add support for TI's IODelay configuration

Tony Lindgren
2015-03-18T01:46:40Z

* Linus Walleij <linus.walleij@linaro.org> [150317 18:31]:
> On Tue, Mar 10, 2015 at 7:33 PM, Nishanth Menon <nm@ti.com> wrote:
> > On 03/10/2015 12:31 PM, Tony Lindgren wrote:
>
> >> Yes except I'd make use of some kind of #pinctrl-cells here just like
> >> interrupt controller has #interrupt-cells. Then you can have the values
> >> seprate and the controller knows what to do with them based on the
> >> compatible flag and #pinctrl-cells.
> >
> > Something like the following I suppose, where pinctrl-cells is optional?
> >
> > dra7_pmx_core: pinmux@4a003400 {
> > compatible = "ti,dra7-padconf", "pinctrl-single";
> > reg = <0x4a003400 0x0464>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> > #interrupt-cells = <1>;
> > interrupt-controller;
> > pinctrl-single,register-width = <32>;
> > pinctrl-single,function-mask = <0x3fffffff>;
> > };
> >
> > dra7_iodelay_core: padconf@4844a000 {
> > compatible = "ti,dra7-iodelay";
> > reg = <0x4844a000 0x0d1c>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> > #pinctrl-cells = <2>;
> > };
> >
> > Linus,
> >
> > I hope you are ok with the above?
>
> Hm depends on where the documentation hits I guess?
>
> Such a generic cell count property has to be to the generic
> pinctrl-bindings.txt document if I read it right.

Yeah agreed. I suggest discussing the binding and the generic
parsing code for it first :)

> Overall I guess this will be acceptable but you really need to
> reuse some more code between this driver and pinctrl-single.c
> if I read it right.

It seems with the generic binding the actual driver should be
just the hardware specific code hopefully.

Regards,

Tony