From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751593AbbCKBKM (ORCPT ); Tue, 10 Mar 2015 21:10:12 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:8908 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbbCKBKI (ORCPT ); Tue, 10 Mar 2015 21:10:08 -0400 X-AuditID: cbfee68e-f79b46d000002b74-7a-54ff95ed56a9 Message-id: <54FF95ED.1040003@samsung.com> Date: Wed, 11 Mar 2015 10:10:05 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Valentin Rothberg Cc: Sylwester Nawrocki , Tomasz Figa , Mike Turquette , Stephen Boyd , Kukjin Kim , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Inki Dae , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Andreas Ruprecht , hengelein Stefan , Paul Bolle , Arnd Bergmann , =?UTF-8?B?Iuq5gOq1reynhEBrZXJuZWwub3JnIg==?= Subject: Re: ARCH_EXYNOS5433 missing in Kconfig References: In-reply-to: Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42JZI2JSoPt26v8Qg+W9+hZ/Jx1jt5h/5Byr Rf+bhawW516tZLSYdH8Ci0X/49fMFpseX2O1uLxrDpvFjPP7mCyWXr/IZPF0wkU2iwnT17JY LLp1htmide8Rdotjr96zWxx+085q8eNMN4tF9/1JbBardv1htPjU3MbsIOKxZt4aRo/fvyYx elzu62Xy+P99KovH+fbZLB47Z91l91i5/Aubx6ZVnWwed67tYfPYvKTeo2/LKkaPjdufMHl8 3iQXwBvFZZOSmpNZllqkb5fAlbF51gTWgpvCFc03/rA1MC4U6GLk5JAQMJG439fKDGGLSVy4 t56ti5GLQ0hgKaPEv/1HWWGKWiauZ4RITGeUmL9hMyuE85pRomtCE1gVr4CWxKObn5lAbBYB VYmv/28xgthsQPH9L26wgdiiAmESK6dfYYGoF5T4MfkemC0iYCRx9PVaZpChzAJdbBL7vvwB axAW0JeY23kbbJCQQIBE1553YLdyCgRLHHncBhZnFlCXmDRvETOELS+xec1bsEESAi84JDq+ vWaEuEhA4tvkQ0DbOIASshKbDkD9LClxcMUNlgmMYrOQ3DQLydhZSMYuYGRexSiaWpBcUJyU XmSkV5yYW1yal66XnJ+7iRGYSk7/e9a3g/HmAetDjAIcjEo8vAwm/0KEWBPLiitzDzGaAl0x kVlKNDkfmLDySuINjc2MLExNTI2NzC3NlMR5E6R+BgsJpCeWpGanphakFsUXleakFh9iZOLg lGpgzF0dcS6Vfbrhlt702O+3rC/xnV9lvu//gsrnkga5q/tYXAxZ95VE+RQpPkhazvNn7vbN 9c8D+VntJDNn7pE8tvW217SHu/S4NxVenTmrRVB5v9cMw+miE943bE9kOih3kcs2a+/NRcy8 l5fJXT41h5Vr+4w+ubxunWmuWRaPNmf+KY+ZHVvOp8RSnJFoqMVcVJwIABvQoHsgAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOKsWRmVeSWpSXmKPExsVy+t9jQd23U/+HGDQcUrH4O+kYu8X8I+dY LfrfLGS1OPdqJaPFpPsTWCz6H79mttj0+BqrxeVdc9gsZpzfx2Sx9PpFJounEy6yWUyYvpbF YtGtM8wWrXuPsFsce/We3eLwm3ZWix9nulksuu9PYrNYtesPo8Wn5jZmBxGPNfPWMHr8/jWJ 0eNyXy+Tx//vU1k8zrfPZvHYOesuu8fK5V/YPDat6mTzuHNtD5vH5iX1Hn1bVjF6bNz+hMnj 8ya5AN6oBkabjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfM HKB/lRTKEnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGENYwZm2dNYC24KVzRfOMP WwPjQoEuRk4OCQETiZaJ6xkhbDGJC/fWs3UxcnEICUxnlJi/YTMrhPOaUaJrQhMrSBWvgJbE o5ufmUBsFgFVia//b4F1swHF97+4wQZiiwqESaycfoUFol5Q4sfke2C2iICRxNHXa5lBhjIL dLFJ7PvyB6xBWEBfYm7nbbBBQgIBEl173jGD2JwCwRJHHreBxZkF1CUmzVvEDGHLS2xe85Z5 AqPALCQ7ZiEpm4WkbAEj8ypG0dSC5ILipPRcQ73ixNzi0rx0veT83E2M4ET1TGoH48oGi0OM AhyMSjy8DCb/QoRYE8uKK3MPMUpwMCuJ8F7O+x8ixJuSWFmVWpQfX1Sak1p8iNEUGAQTmaVE k/OBSTSvJN7Q2MTMyNLI3NDCyNhcSZxXyb4tREggPbEkNTs1tSC1CKaPiYNTCpgo3r6au/rB x+7zB3xd9BvusgS0a1Rn+LJcneRx/PT2fS36d5rq65cp9yxNeXLv2c/jIhkd6Y9/yc316Jgw v+nNv9ufRHvZ33NwiNWF3vIMdWlYqLZpxrlMtw4Zt36mZ/NW3Nd/K61a9D3y0/XXeYI5HXeq NTtm5mYd9pJiDBDZabtTY+PcQ81KLMUZiYZazEXFiQA83Fx1agMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Valentin, I sent the Exynos5433 clock patch and then separately I'm sending the Exynos5433 devicetree patch-set[1]. [1] [PATCH v6 0/9] arm64: Add the support for new Exynos5433 SoC - https://lkml.org/lkml/2015/3/9/1036 But, according to Arnd bergmann's comment[2], latest Exynos5433 dt patch-set[1] removed the CONFIG_ARCH_EXYNOS5433. [2] https://lkml.org/lkml/2015/2/24/85 So, I have plan to send following patch. --- clk: samsung: Use CONFIG_ARCH_EXYNOS instead of Exynos-specific configuration This patch removes the CONFIG_ARCH_EXYNOS{5433|7} and then use only the CONFIG_ARCH_EXYNOS for ARM-64bit Exynos SoC. Cc: Sylwester Nawrocki Cc: Tomasz Figa Cc: Arnd Bergmann Signed-off-by: Chanwoo Choi --- drivers/clk/samsung/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile index 17e9af7..561719d 100644 --- a/drivers/clk/samsung/Makefile +++ b/drivers/clk/samsung/Makefile @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o -obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o +obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o Regards, Chanwoo Choi On 03/11/2015 12:32 AM, Valentin Rothberg wrote: > Hi Chanwoo, > > your commit 96bd6224f07b ("clk: samsung: exynos5433: Add clocks using > common clock framework") is included in today's linux-next tree (i.e., > next-20150310). > > This patch conditionally compiles clk-exynos5433.c depending on the > Kconfig option ARCH_EXYNOS5433. However, this option is not defined > in Kconfig, so that the driver cannot be compiled at the current > state: > > +obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o > > Is there a patch queued somewhere that adds this Kconfig symbol? I > detected the issue by running undertaker-checkpatch from the > Undertaker tool suite (undertaker.cs.fau.de). There is also a tool in > the git tree that can detect such issues (i.e., > scripts/checkkconfigsymbols.py). > > Kind regards, > Valentin >