Re: [PATCH v5 3/4] pci: iproc: Add Broadcom iProc PCIe support

Arnd Bergmann
2015-03-10T22:39:35Z

On Tuesday 10 March 2015 15:22:36 Ray Jui wrote:
> > Do you anticipate additional front-end bus interfaces? If not, and maybe
> > even if you do, you might squash everything into pcie-iproc.c. Then you
> > only need one file (no .h file needed) and the package is a little
> > simpler. I think it's pretty common to have multiple driver registration
> > methods in the same file (OF, PCI, ACPI, etc.) And I think it's common to
> > have those methods guarded by the generic config symbol (CONFIG_PCI,
> > CONFIG_OF, etc.) rather than defining new ones specific to the driver.
> >
>
> Yes I do expect Hauke (CCed) to add BCMA bus front end support later.
>
> I still think having the front end bus driver separated is cleaner and
> may be less troublesome for Hauke to add BCMA support in the future. But
> if you strongly favor having everything stuffed in one single file, I
> can make that change. Please let me know.
>

I was the one that initially suggested splitting the driver into files
like this, and I still think it's the right strategy with the
BCMA driver coming up.

Arnd